Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] Migrate hr_contract_reference. #94

Merged
merged 8 commits into from
May 12, 2015

Conversation

feketemihai
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.24%) to 44.83% when pulling cbc1988 on feketemihai:mig_hr_contract_reference into a96858e on OCA:8.0.

return cid
@api.model
def create(self, vals):
contract = super(hr_contract, self).create(vals)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put before and inject in vals the sequence to avoid 2 operations. Check also if the value is /, and then get the sequence. Any other value, leave it as is. This is for make it easy to work with methods that writes directly a contract number.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.76%) to 45.35% when pulling 9a6360a on feketemihai:mig_hr_contract_reference into a96858e on OCA:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.76%) to 45.35% when pulling 9a6360a on feketemihai:mig_hr_contract_reference into a96858e on OCA:8.0.

:alt: License: AGPL-3

HR Contract Reference
===========
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be of the same length of the title

@coveralls
Copy link

Coverage Status

Coverage increased (+1.76%) to 45.35% when pulling a7acc66 on feketemihai:mig_hr_contract_reference into a96858e on OCA:8.0.

@hbrunn
Copy link
Member

hbrunn commented Apr 21, 2015

👍

@max3903 max3903 added this to the 8.0 milestone Apr 21, 2015
@max3903 max3903 mentioned this pull request Apr 21, 2015
58 tasks
=============

If you want to modify the format of the sequence, go to
Seetings -> Technical -> Sequences & Identifiers -> Sequences
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Settings

@max3903
Copy link
Sponsor Member

max3903 commented Apr 21, 2015

Tested on runbot.

Once typo are fixed
👍

max3903 pushed a commit that referenced this pull request May 12, 2015
@max3903 max3903 merged commit 24a2a11 into OCA:8.0 May 12, 2015
@feketemihai feketemihai deleted the mig_hr_contract_reference branch November 11, 2015 05:10
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
…costs_amend

[BSSFL-11] Add missing README to module
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
BSIBSO-1014 : employee form and kanban changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants