Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][IMP] hr_employee_ppe: Tests and fixes #975

Merged
merged 1 commit into from Feb 28, 2021
Merged

[12.0][IMP] hr_employee_ppe: Tests and fixes #975

merged 1 commit into from Feb 28, 2021

Conversation

marcelsavegnago
Copy link
Member

No description provided.

@marcelsavegnago marcelsavegnago changed the title [12.0][IMP] Tests and fixes [12.0][IMP] hr_employee_ppe: Tests and fixes Feb 20, 2021
@marcelsavegnago marcelsavegnago force-pushed the 12.0-hr_employee_ppe-fixes_and_adding_tests branch from e7606ad to be16e24 Compare February 20, 2021 18:36
etobella
etobella requested changes Feb 22, 2021
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and I found some issues.

Maybe the errors were from before, but they exist.

If you select expirable, the end_date should be required.

hr_employee_ppe/models/hr_employee_ppe.py Outdated Show resolved Hide resolved
@marcelsavegnago marcelsavegnago force-pushed the 12.0-hr_employee_ppe-fixes_and_adding_tests branch 3 times, most recently from 761ee2d to 60f9532 Compare February 24, 2021 15:35
@marcelsavegnago
Copy link
Member Author

ping @eduaparicio

@marcelsavegnago
Copy link
Member Author

ping @etobella

@marcelsavegnago
Copy link
Member Author

ping @OCA/human-resources-maintainers

@marcelsavegnago marcelsavegnago mentioned this pull request Feb 27, 2021
Merged
@Saran440
Copy link
Member

Travis is green 👍
@marcelsavegnago Please, you rebase commit into 1.

@marcelsavegnago marcelsavegnago force-pushed the 12.0-hr_employee_ppe-fixes_and_adding_tests branch from 60f9532 to 5d188dc Compare February 27, 2021 17:16
@marcelsavegnago
Copy link
Member Author

Travis is green 👍
@marcelsavegnago Please, you rebase commit into 1.

@Saran440 done.

@marcelsavegnago
Copy link
Member Author

@Saran440 all green

Saran440
Saran440 reviewed Feb 28, 2021
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge miner

@Saran440
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-975-by-Saran440-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fbb65e8 into OCA:12.0 Feb 28, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 01b4ea4. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 12.0-hr_employee_ppe-fixes_and_adding_tests branch March 1, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saran440 Saran440 Saran440 left review comments

@rvalyi rvalyi rvalyi approved these changes

@eduaparicio eduaparicio eduaparicio approved these changes

@etobella etobella Awaiting requested review from etobella

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@marcelsavegnago @Saran440 @OCA-git-bot @rvalyi @eduaparicio @etobella