Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_harmonized_system_delivery #270

Merged

Conversation

AndreuOForgeFlow
Copy link

Standard migration

Please, see this FIX PR before merging this module for optimal use: #268

@ForgeFlow

Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this small improvement could be added I guess. The rest looks great 👍🏿

Comment on lines +10 to +12
hs_code = fields.Char(related="hs_code_id.hs_code", store=True)
country_of_origin = fields.Many2one(related="origin_country_id", store=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hs_code = fields.Char(related="hs_code_id.hs_code", store=True)
country_of_origin = fields.Many2one(related="origin_country_id", store=True)
# IMPORTANT: Overwrites two Odoo standard fields
hs_code = fields.Char(related="hs_code_id.hs_code", store=True)
country_of_origin = fields.Many2one(related="origin_country_id", store=True)

@AndreuOForgeFlow AndreuOForgeFlow force-pushed the 17.0-mig-product_harmonized_system_delivery branch from bbb21f3 to 6b4c2de Compare March 15, 2024 15:05
alexis-via and others added 28 commits March 18, 2024 09:36
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: intrastat-extrastat-14.0/intrastat-extrastat-14.0-product_harmonized_system_delivery
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-14-0/intrastat-extrastat-14-0-product_harmonized_system_delivery/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: intrastat-extrastat-14.0/intrastat-extrastat-14.0-product_harmonized_system_delivery
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-14-0/intrastat-extrastat-14-0-product_harmonized_system_delivery/
This commit is the "followup" of the change to company_dependent=False
on the fields hs_code_id on product.template and product.category.
Add groupby on hs_code_id on product.template search view
hs.code is now company_id=False by default
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: intrastat-extrastat-15.0/intrastat-extrastat-15.0-product_harmonized_system_delivery
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-15-0/intrastat-extrastat-15-0-product_harmonized_system_delivery/
Alexis de Lattre and others added 8 commits March 18, 2024 09:36
Currently translated at 100.0% (5 of 5 strings)

Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/
Currently translated at 100.0% (5 of 5 strings)

Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/es/
Currently translated at 100.0% (5 of 5 strings)

Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/it/
@AndreuOForgeFlow AndreuOForgeFlow force-pushed the 17.0-mig-product_harmonized_system_delivery branch from 7a8467c to 1e78f27 Compare March 18, 2024 08:36
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏿 Thank you for adding the suggestion 😄

Copy link

@CarlosVForgeFlow CarlosVForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@GuillemCForgeFlow
Copy link

Hi @alexis-via same for this one, could we merge it? 😄

@AndreuOForgeFlow
Copy link
Author

Hi @alexis-via, I guess this module is ready to be merged too? Also, we could add it to the Migration ToDo list.

@gurneyalex
Copy link
Member

/ocabot migration product_harmonized_system_delivery

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 9, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 9, 2024
6 tasks
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-270-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 9, 2024
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-270-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2631efb into OCA:17.0 Apr 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3301550. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 17.0-mig-product_harmonized_system_delivery branch April 9, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet