-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] product_harmonized_system_delivery #270
[17.0][MIG] product_harmonized_system_delivery #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this small improvement could be added I guess. The rest looks great 👍🏿
hs_code = fields.Char(related="hs_code_id.hs_code", store=True) | ||
country_of_origin = fields.Many2one(related="origin_country_id", store=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hs_code = fields.Char(related="hs_code_id.hs_code", store=True) | |
country_of_origin = fields.Many2one(related="origin_country_id", store=True) | |
# IMPORTANT: Overwrites two Odoo standard fields | |
hs_code = fields.Char(related="hs_code_id.hs_code", store=True) | |
country_of_origin = fields.Many2one(related="origin_country_id", store=True) |
bbb21f3
to
6b4c2de
Compare
…e field) Finalize port to v11
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: intrastat-extrastat-14.0/intrastat-extrastat-14.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-14-0/intrastat-extrastat-14-0-product_harmonized_system_delivery/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: intrastat-extrastat-14.0/intrastat-extrastat-14.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-14-0/intrastat-extrastat-14-0-product_harmonized_system_delivery/
This commit is the "followup" of the change to company_dependent=False on the fields hs_code_id on product.template and product.category. Add groupby on hs_code_id on product.template search view hs.code is now company_id=False by default
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: intrastat-extrastat-15.0/intrastat-extrastat-15.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-15-0/intrastat-extrastat-15-0-product_harmonized_system_delivery/
Currently translated at 100.0% (5 of 5 strings) Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/
Currently translated at 100.0% (5 of 5 strings) Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/es/
Currently translated at 100.0% (5 of 5 strings) Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system_delivery Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system_delivery/it/
7a8467c
to
1e78f27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏿 Thank you for adding the suggestion 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
Hi @alexis-via same for this one, could we merge it? 😄 |
Hi @alexis-via, I guess this module is ready to be merged too? Also, we could add it to the Migration ToDo list. |
/ocabot migration product_harmonized_system_delivery |
/ocabot merge nobump |
On my way to merge this fine PR! |
It looks like something changed on |
Congratulations, your PR was merged at 3301550. Thanks a lot for contributing to OCA. ❤️ |
Standard migration
Please, see this FIX PR before merging this module for optimal use: #268
@ForgeFlow