Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Avoid error "The record has been modified, your changes will be discarded" #50

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

alexis-via
Copy link
Contributor

Avoid error "The record has been modified, your changes will be discarded. Are you sure you want to leave this page ?"

@luc-demeyer This is the bug you were looking for...

… discarded. Are you sure you want to leave this page ?"
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1

@pedrobaeza pedrobaeza merged commit 2a87b50 into OCA:10.0 Oct 6, 2018
@luc-demeyer
Copy link
Contributor

@alexis-via
I was just about to make the exact same PR but you took me in speed.
The widget="char" on an integer works ok in 8.0 but not in 10.0.
This PR brings us back to the 'ugly' view where the year 2018 is presented with a dot after the 2 -> 2.018.

We could work around it by turning this field into a real char field but we may break some localisation modules.

I propose that we take this approach in the 11.0 port.

@rvalyi
Do you agree to modify #47 like that ?

@alexis-via
Copy link
Contributor Author

I'm OK to modify this field to char in v11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants