-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate all modules from v11 to v12 #70
Conversation
Could you check the following post, please? |
Hello @moylop260 |
Hello @rvalyi |
@moylop260 in doubt: what is the thing that annoys you really here? Is it the way the 12.0 branch was started or is it the per-module PR rule, or both? |
I saw 68 commits for 11.0 branch: It PR talk about migrate all modules but it has just 4 commits. Maybe I'm missing something special for this report. |
Hello @moylop260
then, like during the 6.1->7.0 and 7.0->8.0 migrations the modules were set as And so these 4 commits here are really just the migration commits, albeit not PR module as expected (yet these are simple changes). In case one still think this is a problem I can assist to rebuild the 12.0 branch and do the cherry-pick/migration PRs. Let me know. |
@moylop260 do you have it clear or need extra explanations? I have to say that I don't like too much to have several modules migrated at the same time in the same PR, but I'm not going to block it as I don't contribute directly to this repo. |
No description provided.