Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0]Add hs_code_link #20

Merged
merged 1 commit into from
Jul 27, 2017
Merged

[10.0]Add hs_code_link #20

merged 1 commit into from
Jul 27, 2017

Conversation

leemannd
Copy link

Odoo added a field char field hs_code in the delivery module.
It results in a duplicate field from product_harmonized_system and it can be
seen twice in the product.template form view.

The goal of this module is to hide Odoo's field in the form and make it related
to the OCA's one if it is used elsewhere.

This module is set as auto_install if the following modules are installed:

  • product_harmonized_system
  • delivery

@coveralls
Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage increased (+0.3%) to 48.105% when pulling 3e3f4e4 on leemannd:add_10-hs_code_link into 357790f on OCA:10.0.

@leemannd
Copy link
Author

@alexis-via @luc-demeyer @gurneyalex Can you review please?

@coveralls
Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage increased (+0.3%) to 48.105% when pulling 24998ff on leemannd:add_10-hs_code_link into 357790f on OCA:10.0.


hs_code = fields.Char(
related='hs_code_id.hs_code',
readonly=True,
Copy link
Member

@gurneyalex gurneyalex Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want store=True too in case this is used in some reports.

<odoo>

<record id="view_template_hide_hs" model="ir.ui.view">
<field name="name">product.template.hs.hiden</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking: "hidden"

@coveralls
Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage increased (+0.3%) to 48.105% when pulling 0e7ade0 on leemannd:add_10-hs_code_link into 357790f on OCA:10.0.

@coveralls
Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage increased (+0.3%) to 48.105% when pulling 0e7ade0 on leemannd:add_10-hs_code_link into 357790f on OCA:10.0.

Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 48.105% when pulling ea27474 on leemannd:add_10-hs_code_link into 357790f on OCA:10.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 48.105% when pulling ea27474 on leemannd:add_10-hs_code_link into 357790f on OCA:10.0.

@tafaRU tafaRU merged commit 44177f6 into OCA:10.0 Jul 27, 2017
@leemannd leemannd deleted the add_10-hs_code_link branch July 27, 2017 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants