-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] iot_input_oca: Migration to 16.0 #87
Conversation
Adds active field in device, input Adds device_identification and passphrase in device Adds address field in input Adds new controller that can take multi event and/or multi input data Updates tests [FIX] Don't remove existing users from security group Updating the module removed existing users from Manager group. This changes behaviour so that users that are already in this group are not removed.
In memory restricted devices (e.g. arduinos et all) sending the input address as number instead of string in the JSON object can save precious memory bytes. This patch allows passing address as number in the JSON object and converting it to string when parsing.
-Sets default order to name for iot_device and iot_input -Skips parsing data for inactive inputs
Currently translated at 87.5% (35 of 40 strings) Translation: iot-15.0/iot-15.0-iot_input_oca Translate-URL: https://translation.odoo-community.org/projects/iot-15-0/iot-15-0-iot_input_oca/ca/
Currently translated at 100.0% (40 of 40 strings) Translation: iot-15.0/iot-15.0-iot_input_oca Translate-URL: https://translation.odoo-community.org/projects/iot-15-0/iot-15-0-iot_input_oca/it/
Currently translated at 100.0% (40 of 40 strings) Translation: iot-15.0/iot-15.0-iot_input_oca Translate-URL: https://translation.odoo-community.org/projects/iot-15-0/iot-15-0-iot_input_oca/it/
@etobella would you help me with the new PR, please? |
/ocabot merge nobump |
Sorry @mostafabarmshory you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment from my side
iot_input_oca/__manifest__.py
Outdated
"author": "Creu Blanca, Odoo Community Association (OCA)", | ||
"category": "IoT/iot_input_oca", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not change category
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, keep the original value "IoT"
@etobella The latest one is about an if condition check, that never happened. I could not create a test to cover this part. Do you have any idea? see this: https://github.com/OCA/iot/pull/87/checks?check_run_id=13992391413 |
/ocabot merge nobump |
Sorry @mostafabarmshory you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
CAn you squash all your commits on a single one? |
@etobella What should I do with the Codecove issue? The current state is acceptable? |
Don't worry. It is good enough 😉 |
345d1ad
to
fe0f6ae
Compare
tx bro, It's ok. I've squashed them all. Would you check pleas? |
Sorry @mostafabarmshory you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments before merge
iot_input_oca/__manifest__.py
Outdated
"author": "Creu Blanca, Odoo Community Association (OCA)", | ||
"category": "IoT/iot_input_oca", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, keep the original value "IoT"
I keep the origin. Codecove is ignored. |
It is not an issue to ignore codecov if there is a good reason, sometimes, there is code that cannot be tested by the tests, but we keep it as it might be important in some cases. Thanks for the migration /ocabot merge nobump |
On my way to merge this fine PR! |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 2aff2fb. Thanks a lot for contributing to OCA. ❤️ |
I add and test the iot_input_oca.