Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] iot_input_oca: Migration to 16.0 #87

Merged
merged 19 commits into from
Jun 15, 2023
Merged

[MIG] iot_input_oca: Migration to 16.0 #87

merged 19 commits into from
Jun 15, 2023

Conversation

mostafabarmshory
Copy link

I add and test the iot_input_oca.

etobella and others added 18 commits June 3, 2023 16:51
Adds active field in device, input
Adds device_identification and passphrase in device
Adds address field in input
Adds new controller that can take multi event and/or multi input data
Updates tests
[FIX] Don't remove existing users from security group
Updating the module removed existing users from Manager group.
This changes behaviour so that users that are already in this group
are not removed.
In memory restricted devices (e.g. arduinos et all) sending the input
address as number instead of string in the JSON object can save precious
memory bytes.
This patch allows passing address as number in the JSON object and
converting it to string when parsing.
-Sets default order to name for iot_device and iot_input
-Skips parsing data for inactive inputs
Currently translated at 87.5% (35 of 40 strings)

Translation: iot-15.0/iot-15.0-iot_input_oca
Translate-URL: https://translation.odoo-community.org/projects/iot-15-0/iot-15-0-iot_input_oca/ca/
Currently translated at 100.0% (40 of 40 strings)

Translation: iot-15.0/iot-15.0-iot_input_oca
Translate-URL: https://translation.odoo-community.org/projects/iot-15-0/iot-15-0-iot_input_oca/it/
Currently translated at 100.0% (40 of 40 strings)

Translation: iot-15.0/iot-15.0-iot_input_oca
Translate-URL: https://translation.odoo-community.org/projects/iot-15-0/iot-15-0-iot_input_oca/it/
@mostafabarmshory
Copy link
Author

@etobella would you help me with the new PR, please?

@mostafabarmshory
Copy link
Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @mostafabarmshory you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment from my side

"author": "Creu Blanca, Odoo Community Association (OCA)",
"category": "IoT/iot_input_oca",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change category

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, keep the original value "IoT"

@mostafabarmshory
Copy link
Author

@etobella
It seems we have to resolve CodeCov test coverage problems.
I've tried to fix some.

The latest one is about an if condition check, that never happened. I could not create a test to cover this part.

Do you have any idea?

see this:

https://github.com/OCA/iot/pull/87/checks?check_run_id=13992391413

@mostafabarmshory
Copy link
Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @mostafabarmshory you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@etobella
Copy link
Member

etobella commented Jun 8, 2023

CAn you squash all your commits on a single one?

@mostafabarmshory
Copy link
Author

@etobella
Yes, I`ll squash them all. sorry bro I was on a journey. sorry for my late response.

What should I do with the Codecove issue? The current state is acceptable?

@etobella
Copy link
Member

Don't worry. It is good enough 😉

@mostafabarmshory
Copy link
Author

@etobella

Don't worry. It is good enough wink

tx bro, It's ok. I've squashed them all. Would you check pleas?

@OCA-git-bot
Copy link
Contributor

Sorry @mostafabarmshory you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments before merge

"author": "Creu Blanca, Odoo Community Association (OCA)",
"category": "IoT/iot_input_oca",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, keep the original value "IoT"

iot_input_oca/__manifest__.py Outdated Show resolved Hide resolved
iot_input_oca/controller/iot_input_controller.py Outdated Show resolved Hide resolved
iot_input_oca/controller/iot_input_controller.py Outdated Show resolved Hide resolved
iot_input_oca/controller/iot_input_controller.py Outdated Show resolved Hide resolved
@mostafabarmshory
Copy link
Author

@etobella

I keep the origin. Codecove is ignored.

@etobella
Copy link
Member

It is not an issue to ignore codecov if there is a good reason, sometimes, there is code that cannot be tested by the tests, but we keep it as it might be important in some cases.

Thanks for the migration

/ocabot merge nobump
/ocabot migration iot_input_oca

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 14, 2023
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-87-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 14, 2023
5 tasks
OCA-git-bot added a commit that referenced this pull request Jun 14, 2023
Signed-off-by etobella
@etobella
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-87-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f093ff1 into OCA:16.0 Jun 15, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2aff2fb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants