[10.0] Improve document_page_approval #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max3903
approved these changes
Jun 1, 2018
…s, and removed workflow engine.
…istory names and summary
…field on document_page
…(), hence always giving the user Approving rights.
|
Hi @max3903 ! I'd like to start migrating this feature to 11.0, but it would only make sense if this PR is merged first. The 9.0 PR containing the exact same changes as this one was already merged, but for some reason this one was left behind. |
|
I proceed with merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #168
Same as #163, but for 10.0