[ADD] document_url: A module that allows to put URLs as attached documents. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ############################################################################## | ||
| # | ||
| # OpenERP, Open Source Management Solution | ||
| # Copyright (C) 2004-2010 Tiny SPRL (<http://tiny.be>). |
There was a problem hiding this comment.
is this correct and up to date?
|
@gurneyalex, I have addressed your remarks, except one, that I have commented. |
| @@ -13,10 +14,8 @@ install: | |||
| - git clone https://github.com/OCA/maintainer-quality-tools.git ${HOME}/maintainer-quality-tools | |||
| - export PATH=${HOME}/maintainer-quality-tools/travis:${PATH} | |||
| - travis_install_nightly ${VERSION} | |||
There was a problem hiding this comment.
giving the version as commandline argument is deprecated from my understanding
There was a problem hiding this comment.
You're right. I'll update it.
pedrobaeza
force-pushed
the
7.0-document_url
branch
from
2a04fd6
to
52d7eb8
Compare
| redraw: function() { | ||
| var self = this; | ||
| this._super.apply(this, arguments); | ||
| self.$el.find('.oe_sidebar_add_attachment').after(QWeb.render('AddUrlDocumentItem', {widget: self})) |
There was a problem hiding this comment.
Why don't you inject the element by extending Sidebar in your qweb file?
There was a problem hiding this comment.
My knowledge in JS is very limited and I copied/pasted the code from Google documents standard module.
|
@hbrunn , can you please re-review this? |
|
👍 |
|
@pedrobaeza sorry for the delay, I'm fine with the code as it is 👍 |
hbrunn
added a commit
that referenced
this pull request
Oct 20, 2014
[ADD] document_url: A module that allows to put URLs as attached documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.