[11.0][MIG] attachment_preview #175
Conversation
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
|
Travis is red |
|
Is this still needed with the new preview option for PDF and images in core? |
|
@pedrobaeza I'm not aware of these options is this an option on the binary widget? |
|
Yeah, not on binary widgets, but attachments do, so you should rip off that one, and maybe adapt for the binary part the standard Odoo mechanism instead of this bloated library. |
|
@pedrobaeza you sure? I've just searched the code for this but can't find anything related |
| @@ -29,6 +29,7 @@ env: | |||
| install: | |||
| - git clone https://github.com/OCA/maintainer-quality-tools.git ${HOME}/maintainer-quality-tools | |||
| - export PATH=${HOME}/maintainer-quality-tools/travis:${PATH} | |||
| - pip install --upgrade python-magic | |||
There was a problem hiding this comment.
Why not adding this to requirements.txt file?
There was a problem hiding this comment.
@tarteo, please, can you explain us this?
I mean on attachments on chatter, not on the "Attachments" dropdown. |
|
👍 |
|
🆙 👍 |
|
@SalahAdDin Can you review with the Github system. It's under the tab 'Files changed'. |
|
@tarteo please squash commits, I think we can merge then |
[FIX] Lint [FIX] lint and flake [ADD] tests [ADD] tests [ADD] tests [ADD] Tests [ADD] Package python-magic [ADD] Tests [FIX] Lint
tarteo
force-pushed
the
11.0-mig-attachment_preview
branch
from
a79783e
to
b0cc4ab
Compare
|
@hbrunn Squashed them 😄 |
Supersedes #150