-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] l10n_be_iso20022_pain #10
Conversation
👍 LGTM (code review, no tests) |
{ | ||
'name': 'SEPA Support for Belgium', | ||
'version': '1.0', | ||
'author': 'ACSONE SA/NV', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not add OCA as author ?
The name of the module is confusing and incorrect. A more correct name would be l10n_be_pain.(or l10n_be_iso20022_pain). I think that this module (once renamed) is also the correct place to add the logic for the InitgPty.Id.OrgId.Othr.Id and InitgPty.Id.OrgId.Othr.Issr fields (cf. febelfin specs). I can make a PR for this but prefer to do this on a module with a correct naming. |
f6dcc1f
to
74afc82
Compare
74afc82
to
11bbb66
Compare
@adrienpeiffer I adapted the README. Regarding the InitgPty.Id.OrgId.Othr I'll do something when we have reached a conclusion in OCA/bank-payment#131 and/or OCA/bank-payment#112 |
👍 Thanks ! |
👍 (Code review) |
This PR depends on OCA/bank-payment#80