Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16.0 [MIG] l10n_be_partner_kbo_bce #159

Merged
merged 17 commits into from Jul 19, 2023
Merged

16.0 [MIG] l10n_be_partner_kbo_bce #159

merged 17 commits into from Jul 19, 2023

Conversation

victor-champonnois
Copy link
Member

@victor-champonnois victor-champonnois commented Nov 28, 2022 •
edited

Tests do not work because OCA/partner-contact#1397 needs to be merged first
[fixed]When running pre-commit run -a
I have a prompt that asks me to login to gitlab :

@victor-champonnois victor-champonnois changed the title 16.0 mig l10n be partner kbo bce 16.0 [MIG] l10n_be_partner_kbo_bce Nov 29, 2022
@luc-demeyer
Copy link
Contributor

@victor-champonnois
I think a rebase will fix your problem, cf. aa5e548

@victor-champonnois victor-champonnois force-pushed the 16.0-mig-l10n_be_partner_kbo_bce branch 2 times, most recently from 411e5ac to ffa0283 Compare December 7, 2022 10:14
@victor-champonnois
Copy link
Member Author

@luc-demeyer thanks, it works :)

@luc-demeyer
Copy link
Contributor

@victor-champonnois
Thanks.
Still a small issue since this module depends on OCA partner_identification which is not available for 16.0 yet.
Hence you should port that one first or wait until it's available before we can merge your work here.

remytms
remytms approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marielejeune
Copy link
Contributor

marielejeune commented Dec 8, 2022 •
edited

Hi @victor-champonnois
The migration of partner_identification is ready and just waits for 1 more review before being merged.
Please see OCA/partner-contact#1397
Thanks!

@sbidoul
Copy link
Member

sbidoul commented Dec 8, 2022

@victor-champonnois can you rebase, now that partner_identification is merged?

carmenbianca
carmenbianca suggested changes Jul 12, 2023
View reviewed changes
Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request for change.

l10n_be_partner_kbo_bce/tests/test_l10n_be_partner_kbo_bce.py Outdated
Comment on lines 9 to 12
def setUp(self):
super(TestKboBceNumber, self).setUp()
self.rp_1 = self.env.ref("l10n_be_partner_kbo_bce.res_partner_1")
self.be = self.env.ref("base.be")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use setUpClass, which is more performant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with setupclass instead of super(), but the tests failed. They are not designed to be used with setupclass, it would demand to rewrite them. And I think this is out of scope

l10n_be_partner_kbo_bce/tests/test_l10n_be_partner_kbo_bce.py Outdated

class TestKboBceNumber(TransactionCase):
def setUp(self):
super(TestKboBceNumber, self).setUp()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use plain super()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbidoul
Copy link
Member

sbidoul commented Jul 19, 2023

/ocabot merge patch

@sbidoul
Copy link
Member

sbidoul commented Jul 19, 2023

Thanks!

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-159-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a774c8f into OCA:16.0 Jul 19, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b86df2e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmenbianca carmenbianca carmenbianca approved these changes

@remytms remytms remytms approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@victor-champonnois @luc-demeyer @marielejeune @sbidoul @OCA-git-bot @carmenbianca @remytms @sbejaoui @oca-travis @StefanRijnhart