-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] l10n_be_vat_reports #218
[16.0][MIG] l10n_be_vat_reports #218
Conversation
7e5ff80
to
b6cddd1
Compare
odoo/odoo/tree/8.0/addons/l10n_be https://github.com/odoo/odoo/tree/8.0/addons/l10n_be
This commit fixes two problems with the calculation: - The turnover tax was being fetched from the wrong field - Move lines with taxes that had more than one tag where being summed more than once Use -balance for turnover and tax
They were being created in l10n_be
[IMP] remove commented code
Belgian VAT number now can start with a 1 rather than a 0 (see https://www.easytax.co/fr/tax-mag/info/belgique-changement-de-format-pour-les-numeros-de-tva-belges/)
c4b8025
to
fd0597c
Compare
user_type_id -> account_type account.account.type to comply with 26b2472f4977ccedbb0b5ed5f08be2c04313fd21 fix vat report
a0e5b44
to
64ff823
Compare
- remove "or" between buttons - put buttons in header rather than footer - improve form layout - rename Intracom report name
64ff823
to
1e7364f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested functionnally this module in v16. It works exactly like in v12 (the version I know best).
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at b86aab1. Thanks a lot for contributing to OCA. ❤️ |
Suggestions for making my changes cleaner are welcome!
this PR also port the changes in #217