Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] l10n_be_vat_reports #218

Merged
merged 63 commits into from
Apr 19, 2024

Conversation

victor-champonnois
Copy link
Member

@victor-champonnois victor-champonnois commented Mar 7, 2024

Suggestions for making my changes cleaner are welcome!

this PR also port the changes in #217

@victor-champonnois victor-champonnois marked this pull request as ready for review March 12, 2024 13:58
robinkeunen and others added 28 commits March 12, 2024 14:59
This commit fixes two problems with the calculation:

- The turnover tax was being fetched from the wrong field
- Move lines with taxes that had more than one tag where being
summed more than once
Use -balance for turnover and tax
@victor-champonnois victor-champonnois force-pushed the 16.0-mig-l10n_be_vat_reports branch 2 times, most recently from c4b8025 to fd0597c Compare March 12, 2024 14:58
user_type_id -> account_type account.account.type

to comply with 26b2472f4977ccedbb0b5ed5f08be2c04313fd21

fix vat report
@victor-champonnois victor-champonnois force-pushed the 16.0-mig-l10n_be_vat_reports branch 2 times, most recently from a0e5b44 to 64ff823 Compare March 12, 2024 15:08
- remove "or" between buttons
- put buttons in header rather than footer
- improve form layout
- rename Intracom report name
Copy link
Contributor

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review. LGTM.

@vdewulf vdewulf self-requested a review March 14, 2024 11:17
Copy link
Contributor

@vdewulf vdewulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested functionnally this module in v16. It works exactly like in v12 (the version I know best).

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand tag's behaviour but trusting the review by @remytms and @vdewulf 's review and test. The rests looks good.

@robinkeunen
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-218-by-robinkeunen-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6bd4089 into OCA:16.0 Apr 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b86aab1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants