Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0 l10n ca hr payroll #16

Closed
wants to merge 27 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2014

Added Canada income tax deductions and employee benefits.
Corrected the canadian salary rules and added missing rules.
Removed unused fields in hr.employee.

@ghost ghost closed this Sep 19, 2014
@ghost ghost reopened this Sep 19, 2014
'table_id', 'Lines'),
'line_csst_ids': fields.one2many('hr.payroll.tax.table.csst.line',
'table_id', 'Lines'),
'name': fields.char('Category Name', size=256, required=True),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a strong reason to enforce a size limit on this field, the size parameter is not necessary.



class hr_benefit_category(orm.Model):
_inherit = 'hr.benefit.category'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name python file after the model/class

@max3903
Copy link
Sponsor Member

max3903 commented Oct 7, 2014

Can you split this PR ? One module per PR is easier to review.
Thanks.

@ghost ghost closed this Oct 7, 2014
@ghost ghost deleted the 7.0-l10n_ca_hr_payroll branch October 7, 2014 13:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants