17.0 credit note #69

rvjaraj · 2024-05-10T05:27:58Z

CREDIT NOTE

Migración de v15 to v17

jorge-luis-dev

Exelente!!! Ya lo probé. Saludos

…ounts in Ecuador [MOD] changes credit note by 17.0 [ADD] Wizard and control account by line [ADD] Compute view form account in line invoice [MOD] Control account anglo saxon out lines [FIX] Anglo account and remove context [FIX] pre-commit [FIX] Remove Context [ADD] Test module [ADD] Test module [ADD] Test module [ADD] Test module post [FXI] Test module witch post [FXI] Test module witch post y# This is a combination of 6 commits. [ADD] stock_account dependes [FIX] Anglo test [FIX] pre-commit [FIX] pre-commit and codecov [MOD] changes credit note by 17.0 [FIX] pre-commit [ADD] Test Implementation [FIX] Dependencies and remove context [ADD] Test module [ADD] Test module [ADD] Test module [ADD] Test module post [FXI] Test module witch post [FXI] Test module witch post [ADD] stock_account dependes [FIX] Anglo test [FIX] pre-commit [FIX] pre-commit and codecov [FIX] refactor test a code [FIX] pre-commit [FIX] codecov [FIX] refactor test a code [FIX] refactor test a code [FIX] refactor test a code [FIX] Config view migration [ADD] i18n [IMP] l10n_ec_account_edi: Add email notification when certificate is expired [IMP] l10n_ec_account_edi: Cron for check unauthorized electronic documents [UPD] Update l10n_ec_account_edi.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-ecuador-17.0/l10n-ecuador-17.0-l10n_ec_account_edi Translate-URL: https://translation.odoo-community.org/projects/l10n-ecuador-17-0/l10n-ecuador-17-0-l10n_ec_account_edi/ Restaurar l10n_ec_account_edi y l10n_ec_base desde la rama 17.0 del repositorio original

celm1990 · 2024-07-24T01:43:52Z

@rvjaraj Please update your branch according to these changes: #71 to fix the tests

rvjaraj · 2024-07-24T17:15:37Z

@celm1990 Branch Update

celm1990

@rvjaraj, thanks for your contribution. I have provided my comments for a first technical review. Let me know if you have any questions or need further clarification.

l10n_ec_credit_note/__manifest__.py

celm1990 · 2024-07-27T02:21:58Z

l10n_ec_credit_note/models/account_move.py

+
+from odoo import api, fields, models
+
+_logger = logging.getLogger(__name__)


remove if not is used

l10n_ec_credit_note/models/account_move.py

celm1990 · 2024-07-27T02:40:50Z

l10n_ec_credit_note/models/account_move.py

+
+    def copy_data(self, default=None):
+        res = super().copy_data(default=default)
+        if self._context.get("move_reverse_cancel"):


Apply these changes only if it is an Ecuadorian company.

celm1990 · 2024-07-27T02:41:09Z

l10n_ec_credit_note/models/account_move_line.py

+
+from odoo import models
+
+_logger = logging.getLogger(__name__)


remove if not is used

celm1990 · 2024-07-27T02:59:42Z

l10n_ec_credit_note/views/product_category_view.xml

+        <field name="inherit_id" ref="account.view_category_property_form" />
+        <field name="arch" type="xml">
+            <group name="account_property" position="inside">
+                <group string="Credit Note">


Suggested change

<group string="Credit Note">

<group string="Credit Note(Only for Ecuadorian Companies)">

celm1990 · 2024-07-27T03:00:15Z

l10n_ec_credit_note/views/product_template_view.xml

+        <field name="inherit_id" ref="account.product_template_form_view" />
+        <field name="arch" type="xml">
+            <group name="payables" position="after">
+                <group string="Credit Note">


Suggested change

<group string="Credit Note">

<group string="Credit Note(Only for Ecuadorian Companies)">

celm1990 · 2024-07-27T03:02:58Z

l10n_ec_credit_note/views/res_config_view.xml

+                                />
+                                <field
+                                    name="l10n_ec_property_account_discount_id"
+                                    placeholder="Same Account"


What do you mean by "Same Account"? It's better to leave this placeholder empty because it is confusing.

celm1990 · 2024-07-27T03:03:07Z

l10n_ec_credit_note/views/res_config_view.xml

+                                />
+                                <field
+                                    name="l10n_ec_property_account_return_id"
+                                    placeholder="Same Account"


celm1990 · 2024-07-27T03:10:42Z

l10n_ec_credit_note/models/account_move.py

+    def _reverse_moves(self, default_values_list=None, cancel=False):
+        reverse_moves = super()._reverse_moves(
+            default_values_list=default_values_list, cancel=cancel
+        )
+        if (
+            self.company_id.account_fiscal_country_id.code == "EC"
+            and reverse_moves.filtered(
+                lambda x: x.l10n_ec_type_credit_note and x.move_type in ["out_refund"]
+            )
+        ):
+            rev_mov_fil = reverse_moves.filtered(
+                lambda x: x.l10n_ec_type_credit_note and x.move_type in ["out_refund"]
+            )
+            rev_mov_lines = rev_mov_fil.with_context(skip_invoice_sync=cancel).mapped(
+                "line_ids"
+            )
+            for reverse_move_line in rev_mov_lines.filtered(
+                lambda x: x.display_type == "product"
+            ):
+                reverse_move_line.account_id = self._get_account_product_line(
+                    reverse_move_line
+                )
+        return reverse_moves


Can this code be handled at a different time or in another function (e.g., on functions copy or copy_data)? I see it as risky because when the super call occurs, the record might already be posted, and it could be problematic to try changing the account if the document is already posted.
https://github.com/odoo/odoo/blob/96b3ffc2394be46a4f7a44b7a618a7ee8f2c594f/addons/account/models/account_move.py#L3768

celm1990 · 2024-07-27T03:31:09Z

l10n_ec_credit_note/views/res_config_view.xml

+        />
+        <field name="arch" type="xml">
+            <xpath expr="//div[@id='l10n_ec_section']" position="inside">
+                <block title="Credit Note" id="l10n_ec_credit_note">


Remove block element and only keep setting element into another block

Approved Co-authored-by: Carlos Lopez <celm1990@hotmail.com>

Co-authored-by: Carlos Lopez <celm1990@hotmail.com>

rvjaraj closed this May 10, 2024

rvjaraj reopened this May 10, 2024

rvjaraj force-pushed the 17.0-credit-note branch 3 times, most recently from 9cf5a5a to a8c0597 Compare June 13, 2024 16:49

jorge-luis-dev approved these changes Jun 19, 2024

View reviewed changes

rvjaraj force-pushed the 17.0-credit-note branch 3 times, most recently from ef4ea74 to 20c9dd5 Compare July 5, 2024 21:55

rvjaraj force-pushed the 17.0-credit-note branch from 20c9dd5 to 3d5df16 Compare July 5, 2024 22:13

Merge branch 'OCA:17.0' into 17.0-credit-note

8a90d4f

Merge branch 'OCA:17.0' into 17.0-credit-note

da6373a

celm1990 requested changes Jul 27, 2024

View reviewed changes

celm1990 reviewed Jul 27, 2024

View reviewed changes

rvjaraj and others added 2 commits July 31, 2024 12:47

Update l10n_ec_credit_note/__manifest__.py

75f2764

Approved Co-authored-by: Carlos Lopez <celm1990@hotmail.com>

approved

1e3080c

Co-authored-by: Carlos Lopez <celm1990@hotmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

17.0 credit note #69

17.0 credit note #69

rvjaraj commented May 10, 2024 •

edited

Loading

jorge-luis-dev left a comment

celm1990 commented Jul 24, 2024

rvjaraj commented Jul 24, 2024

celm1990 left a comment

celm1990 Jul 27, 2024

rvjaraj Jul 31, 2024

celm1990 Jul 27, 2024

rvjaraj Jul 31, 2024 •

edited

Loading

celm1990 Jul 27, 2024

rvjaraj Jul 31, 2024

celm1990 Jul 27, 2024

celm1990 Jul 27, 2024

celm1990 Jul 27, 2024

celm1990 Jul 27, 2024

celm1990 Jul 27, 2024

celm1990 Jul 27, 2024


		from odoo import api, fields, models

		_logger = logging.getLogger(__name__)


		from odoo import models

		_logger = logging.getLogger(__name__)

	<group string="Credit Note">
	<group string="Credit Note(Only for Ecuadorian Companies)">

17.0 credit note #69

Are you sure you want to change the base?

17.0 credit note #69

Conversation

rvjaraj commented May 10, 2024 • edited Loading

jorge-luis-dev left a comment

Choose a reason for hiding this comment

celm1990 commented Jul 24, 2024

rvjaraj commented Jul 24, 2024

celm1990 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rvjaraj Jul 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rvjaraj commented May 10, 2024 •

edited

Loading

rvjaraj Jul 31, 2024 •

edited

Loading