[10.0][ADD] business code and validation #10

jarmokortetjarvi · 2017-10-24T10:55:41Z

Adds a business id for partners.
Split to two modules: one just adds the field and other adds validation and formatting.
This way the validation will be optional, and the module can be installed in environments with incorrectly formatted business ids

Ported from Odoo 8 to Odoo 10

…_edicode

EDI code functionality

Add a new module for business id

Add a new module for business id validation

mlaitinen

There are some minor changes I'd like to see

mlaitinen · 2017-10-24T12:38:31Z

l10n_fi_business_code/data/res_partner_id_category.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>


This is Odoo 10, please use <odoo> and in cases of <openerp><data noupdate="1"> use <odoo noupdate="1">

mlaitinen · 2017-10-24T12:42:31Z

l10n_fi_business_code/views/res_partner.xml

+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
+
+<odoo>
+	<data>


<data> is unnecessary. Also, please check the indentation of this file.

mlaitinen · 2017-10-24T12:42:58Z

l10n_fi_business_code_validate/data/res_partner_id_category.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>


Please change to <odoo>

mlaitinen · 2017-10-24T12:43:54Z

l10n_fi_business_code_validate/models/res_partner_id_number.py

+from odoo.exceptions import ValidationError
+
+
+class ResPartnerIdNumber(models.Model):


What's the purpose of this class?

mlaitinen · 2017-10-24T12:44:52Z

l10n_fi_edicode/data/res_partner_operator_einvoice.xml

@@ -0,0 +1,136 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>


Please use <odoo> instead and check the indentation of this file.

mlaitinen · 2017-10-24T12:45:14Z

l10n_fi_edicode/models/res_partner.py

@@ -0,0 +1,25 @@
+# -*- coding: utf-8 -*-
+from openerp import api, fields, models


from odoo ..

mlaitinen · 2017-10-24T12:45:32Z

l10n_fi_edicode/models/res_partner_operator_einvoice.py

@@ -0,0 +1,13 @@
+# -*- coding: utf-8 -*-
+from openerp import api, fields, models


from odoo ..

mlaitinen · 2017-10-24T12:48:02Z

l10n_fi_edicode/models/res_partner.py

+    )
+    einvoice_operator_identifier = fields.Char(
+        string='Operator ID',
+        compute='get_einvoice_operator_identifier',


Couldn't this be a related field?

mlaitinen · 2017-10-24T12:48:51Z

l10n_fi_edicode/view/res_partner.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>


Use <odoo>, drop <data> and check indentations.

jarmokortetjarvi · 2017-10-24T13:19:07Z

Fixed the formatting issues and removed the edicode-module. It had been merged to a wrong branch

coveralls · 2017-12-19T14:33:48Z

Coverage decreased (-61.7%) to 38.298% when pulling 1dbb08c on Tawasta:10.0-l10n_fi_business_code_validate into a8abb9d on OCA:10.0.

coveralls · 2017-12-19T14:39:42Z

Coverage decreased (-62.0%) to 38.0% when pulling 1dbb08c on Tawasta:10.0-l10n_fi_business_code_validate into a8abb9d on OCA:10.0.

coveralls · 2017-12-19T14:39:42Z

Coverage decreased (-62.0%) to 38.0% when pulling 1dbb08c on Tawasta:10.0-l10n_fi_business_code_validate into a8abb9d on OCA:10.0.

coveralls · 2017-12-20T14:48:32Z

Coverage decreased (-62.7%) to 37.255% when pulling 19ca1bd on Tawasta:10.0-l10n_fi_business_code_validate into a8abb9d on OCA:10.0.

coveralls · 2017-12-20T15:09:30Z

Coverage decreased (-62.7%) to 37.255% when pulling 158fe2b on Tawasta:10.0-l10n_fi_business_code_validate into a8abb9d on OCA:10.0.

coveralls · 2017-12-20T15:09:30Z

Coverage decreased (-62.7%) to 37.255% when pulling 158fe2b on Tawasta:10.0-l10n_fi_business_code_validate into a8abb9d on OCA:10.0.

10.0 l10n fi payment terms format fix

coveralls · 2017-12-29T09:53:33Z

Coverage decreased (-62.7%) to 37.255% when pulling f48107f on Tawasta:10.0-l10n_fi_business_code_validate into a8abb9d on OCA:10.0.

coveralls · 2017-12-29T09:53:33Z

Coverage decreased (-62.7%) to 37.255% when pulling b1e0190 on Tawasta:10.0-l10n_fi_business_code_validate into 769b423 on OCA:10.0.

mlaitinen

LGTM except the payment term module related stuff

mlaitinen · 2018-01-14T17:40:52Z

l10n_fi_payment_terms/README.rst

@@ -8,8 +8,6 @@ Finnish Invoice Payment Terms

 Common Finnish invoice payment terms.

-**Please note that this module will remove the default payment terms!**


Why is l10n_fi_payment_terms in the same PR? You seem to have another PR #12 open for almost the same thing.

…de_validate

mlaitinen · 2018-03-20T09:35:48Z

@jarmokortetjarvi Looks good, but there's still the EDI code module in the README which is yet to be merged. Also there seems to be a merge conflict in the README file.

Fix formatting issues

jarmokortetjarvi · 2018-07-26T10:56:55Z

The commit history was a tangled mess between oca/l10n-finland and tawasta/l10n-finland
Closed this and created a new PR #15 that has only the relevant commits via git subtree. The contents should be pretty much identical

aisopuro · 2018-07-26T08:07:32Z

l10n_fi_business_code/models/res_partner.py

+
+    business_id = fields.Char(
+        string='Business ID',
+        compute=lambda s: s._compute_identification(


Not sure if it's a big problem, but I'll add a note here anyway: using a lambda here means that anyone who wants to extend this model cannot directly extend the computation method of the field business_id in an Odoo-like fashion: they either have to do some pretty gnarly monkeypatching, or extend _compute_identification and trust or ensure that their changes only apply to the computation of this field. I think it would be a little better if we just go the normal route and define real computation methods and then refer to them by string in the field definition.

aisopuro · 2018-07-26T08:11:28Z

l10n_fi_business_code_validate/models/res_partner_id_category.py

+
+        # The formal format is ok, check the validation number
+        multipliers = [7, 9, 10, 5, 8, 4,
+                       2]  # Number-space specific multipliers


Could the comment be above, so the multipliers could fit on a single line?

aisopuro · 2018-07-26T08:18:02Z

l10n_fi_business_code_validate/models/res_partner_id_category.py

+        validation_bit = business_id_number[7:8]
+
+        # Test the validation bit
+        for number in business_id_number[0:7]:


We could iterate over the zip instead:

for number, multiplier in zip(business_id_number[0:7], multipliers): validation_multiplier += multiplier * int(number)

Then we don't need number_index

Timo Talvitie and others added 30 commits June 9, 2015 12:07

Initial commit

08e5f6c

Add finnish translations

b0b956d

Create README.md

d563ed8

Refactor to API v8

8358ca2

Improve README file

3cfc5a9

Improve einvoice operator to be a relation instead of char

0d645ba

Add operator data

bdd210f

Add security rules

01ab7cd

Merge pull request #1 from Tawasta/10.0-l10n_fi_banks

27b54e6

Ported from Odoo 8 to Odoo 10

Merge branch '10.0' of https://github.com/OCA/l10n-finland into 10.0

251dc0b

Refactor directory structure

4dcabfc

Remove an obsolete file

413ce08

Merge remote-tracking branch 'edicode/l10n-finland' into 10.0-l10n_fi…

a041976

…_edicode

Refactor formatting and structure

c47e72d

Improve partner view

f5b711d

Fix user rights

7db5d70

Add Finnish translations

11fff38

Merge pull request #2 from Tawasta/10.0-l10n_fi_edicode

2979de2

EDI code functionality

Improve readme

e89dbca

Add a new module migrated from partner-contact

a9195c1

Add a partner_identification dependent field

6c77a5a

Improve description and naming

067c4f7

Add a finnish translation

dd1d49a

Merge pull request #3 from Tawasta/10.0-l10n_fi_business_code

0ef120e

Add a new module for business id

Add a new module for business id validation

af8e493

Merge pull request #4 from Tawasta/10.0-l10n_fi_business_code_validate

6be1fcb

Add a new module for business id validation

Improve readme

4aba19d

Improve readme

d94f2dc

Improve readme

9efb993

Fix the description

b7aa897

Improve readme

c46df21

jarmokortetjarvi changed the title ~~[10.0][ADD] l10n fi business code validate~~ [10.0][ADD] business code and validation Oct 24, 2017

mlaitinen requested changes Oct 24, 2017

View reviewed changes

jarmokortetjarvi added 2 commits October 24, 2017 16:13

Fix formatting issues

7fc5734

Remove a module (incorrect branch)

856af27

jarmokortetjarvi added 2 commits December 19, 2017 16:19

Add OCA dependencies

24e1181

Add error messages as translatable

1dbb08c

Refactor formatting

19ca1bd

Improve formatting

158fe2b

jarmokortetjarvi added 2 commits December 29, 2017 11:48

Merge pull request #5 from Tawasta/10.0-l10n_fi_payment_terms-format-fix

2949016

10.0 l10n fi payment terms format fix

Merge branch '10.0' into 10.0-l10n_fi_business_code_validate

f48107f

mlaitinen requested changes Jan 14, 2018

View reviewed changes

Merge remote-tracking branch 'oca/10.0' into 10.0-l10n_fi_business_co…

b1e0190

…de_validate

mlaitinen referenced this pull request in avoinsystems/l10n-finland Jun 28, 2018

Merge pull request #10 from Tawasta/10.0-l10n_fi_banks-format-fix

321d099

Fix formatting issues

mlaitinen added the needs fixing label Jul 26, 2018

jarmokortetjarvi closed this Jul 26, 2018

jarmokortetjarvi deleted the 10.0-l10n_fi_business_code_validate branch July 26, 2018 10:10

aisopuro reviewed Jul 27, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0][ADD] business code and validation #10

[10.0][ADD] business code and validation #10

jarmokortetjarvi commented Oct 24, 2017

mlaitinen left a comment

mlaitinen Oct 24, 2017

mlaitinen Oct 24, 2017

mlaitinen Oct 24, 2017

mlaitinen Oct 24, 2017

mlaitinen Oct 24, 2017

mlaitinen Oct 24, 2017

mlaitinen Oct 24, 2017

mlaitinen Oct 24, 2017

mlaitinen Oct 24, 2017

jarmokortetjarvi commented Oct 24, 2017

coveralls commented Dec 19, 2017 •

edited

Loading

coveralls commented Dec 19, 2017

coveralls commented Dec 19, 2017

coveralls commented Dec 20, 2017 •

edited

Loading

coveralls commented Dec 20, 2017

coveralls commented Dec 20, 2017

coveralls commented Dec 29, 2017

coveralls commented Dec 29, 2017 •

edited

Loading

mlaitinen left a comment

mlaitinen Jan 14, 2018

mlaitinen commented Mar 20, 2018

jarmokortetjarvi commented Jul 26, 2018

aisopuro Jul 26, 2018

aisopuro Jul 26, 2018

aisopuro Jul 26, 2018

		@@ -0,0 +1,12 @@
		<?xml version="1.0" encoding="utf-8"?>
		<openerp>

		@@ -0,0 +1,11 @@
		<?xml version="1.0" encoding="utf-8"?>
		<openerp>

		from odoo.exceptions import ValidationError


		class ResPartnerIdNumber(models.Model):

		@@ -0,0 +1,136 @@
		<?xml version="1.0" encoding="utf-8"?>
		<openerp>

		@@ -0,0 +1,25 @@
		# -- coding: utf-8 --
		from openerp import api, fields, models

		@@ -0,0 +1,13 @@
		# -- coding: utf-8 --
		from openerp import api, fields, models

		@@ -0,0 +1,19 @@
		<?xml version="1.0" encoding="UTF-8"?>
		<openerp>

		@@ -8,8 +8,6 @@ Finnish Invoice Payment Terms

		Common Finnish invoice payment terms.

		Please note that this module will remove the default payment terms!

[10.0][ADD] business code and validation #10

[10.0][ADD] business code and validation #10

Conversation

jarmokortetjarvi commented Oct 24, 2017

mlaitinen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jarmokortetjarvi commented Oct 24, 2017

coveralls commented Dec 19, 2017 • edited Loading

coveralls commented Dec 19, 2017

coveralls commented Dec 19, 2017

coveralls commented Dec 20, 2017 • edited Loading

coveralls commented Dec 20, 2017

coveralls commented Dec 20, 2017

coveralls commented Dec 29, 2017

coveralls commented Dec 29, 2017 • edited Loading

mlaitinen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlaitinen commented Mar 20, 2018

jarmokortetjarvi commented Jul 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Dec 19, 2017 •

edited

Loading

coveralls commented Dec 20, 2017 •

edited

Loading

coveralls commented Dec 29, 2017 •

edited

Loading