Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 l10n fr ecotaxe #76

Merged
merged 21 commits into from May 18, 2017
Merged

8.0 l10n fr ecotaxe #76

merged 21 commits into from May 18, 2017

Conversation

mourad-ehm
Copy link

@mourad-ehm mourad-ehm commented Jun 17, 2016

This module manages the Ecotaxe (Recycling Tax) for France.

@oca-clabot
Copy link

Hey @mourad-ehm, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • david (no github login found)

Appreciation of efforts,
OCA CLAbot

self.ecotaxe_coef = 0


class account_invoice_tax(models.Model):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Camel case class name

@bealdav
Copy link
Member

bealdav commented Jul 7, 2016

Nice job, could you add demo data and maybe one test unit.

# Default Section
def _default_company_id(self):
return self.env['res.users']._get_company()

Copy link
Member

@bealdav bealdav Jul 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing, required attribute in some fields below

@mourad-ehm
Copy link
Author

ping @gurneyalex

@gurneyalex gurneyalex merged commit 67c3e66 into OCA:8.0 May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants