[16.0][MIG] l10n_de_tax_statement #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGigSolutions
changed the title
|
Just like in the other module, the failing tests seem to be because of the 4 lines of demo data. |
|
@ortlam, would you mind having a look at this one? |
|
@hbrunn do these test failures make any sense to you? Asking because you migrated the module. |
|
not much, but 196 is the correct value. would have to debug to find out where the extra move lines come from |
|
@MrGigSolutions see here: #148 |
we have cloned and adopted the l10n-netherlands tax report module from Onestein B.V. The report is constructed in the same way as official german „Umsatzsteuervoranmeldung“. The values from the report could be easily transmitted via official portal https://www.elster.de/ in order to declare and transfer your monthly (or quarterly) vat taxes.
…fig wizard most removed tests are not relevant for germany as they was related in the clone from netherlands to invoice basis (related to invoice or account move dates which is probably not relevant for germany). The change in the config wizard was required as the tax tag mappings for the tax statement should work with skr03 and skr04 accounting plans.
The prior change raised an error. The two additional dependencies account_invoicing, l10n_de should help to allow immediate runbot testing without any manual installation steps in advance.
I have applied proposed changes of Andrea Stirpe in order to get through the testing procedure.
The old lines 39 disappeared and was merged together with the old line 40 (now they are line 39 in 2019 edition). Furthermore the old lines 49 and 51 disappeared and was merged into the line 50. There is a relevance for the tax codes (tag_ids). The old tag „USt-VA KZ 68“ have to be mapped to the same line as the tag „USt-VA KZ 60“. The old tags „USt-VA KZ 52“ and „USt-VA KZ 78“ have to be mapped the same way as the old and single remaining „USt-VA 84“ (= base values). The old tags „USt-VA KZ 53“ and „USt-VA KZ 79“ have to be mapped the same way as the old and single remaining „USt-VA KZ 85“ (tax values). Furthermore we might have formatting changes caused by the different line numbering. Therefore i expect further adoptions in the files „l10n_de_tax_statement_line.py“ and also in the „l10n_de_tax_statement_config_wizard.xml“ and the „l10n_de_tax_statement_config_wizard.py“. I assume we cannot avoid deeper changes in order to adopt what we really want.
… compare conversation: OCA#39
Changes: - Adjusted manifest - Removed migrations - Refactored unlink() to @api.ondelete - Removed unused methods and imports from tests - Tests now use setUpClass instead of setUp - Removed widgets from chatter
MrGigSolutions
force-pushed
the
16.0-mig-l10n_de_tax_statement
branch
from
69cae94
to
5c21a00
Compare
MrGigSolutions
force-pushed
the
16.0-mig-l10n_de_tax_statement
branch
from
11a9166
to
80c6a27
Compare
StefanRijnhart
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for 16.0