[10.0] [MIG] l10n_de_steuernummer #23
Conversation
|
cc @Tecnativa |
|
@chienandalu @cubells please review |
| if getattr(vatnumber, 'check_vat_de', None): | ||
| res = vatnumber.check_vat_de(vat) | ||
| if not res: | ||
| # This vat is not a Steue-IdNr., so if it is 10 or 11 digit |
There was a problem hiding this comment.
This vat is not an Steue-IdNr.
There was a problem hiding this comment.
@cubells I think that's not correct. Following grammar rules(https://rayli.net/blog/life/when-to-use-a-or-an/#First_why_the_confusion) a word like Steuer doesn't begin with a vowel sound (although we spanish speakers tend to pronounce such words more like 'es...', than the proper 'ss').
There was a problem hiding this comment.
Anyway s/Steue-IdNr/Steuer-IdNr
There was a problem hiding this comment.
@chienandalu
I'm not an expert english speaker, sure.
So according to you, I made "a stupid comment" or "an stupid comment"?
:)
There was a problem hiding this comment.
@cubells Just an unfortunate observation 😄
| res = vatnumber.check_vat_de(vat) | ||
| if not res: | ||
| # This vat is not a Steue-IdNr., so if it is 10 or 11 digit | ||
| # length then we can assume that this is a old Steuernummer |
There was a problem hiding this comment.
that this is an old Steuernummer
|
|
||
| #. Go to Contacts. | ||
| #. Create a new record. | ||
| #. Put a SteuerNummer in the VAT field preceded by 'DE'. |
There was a problem hiding this comment.
Put an SteuerNummer in the VAT
|
The problem is an outdated .travis.yml. You can update it in a separate PR. |
|
@pedrobaeza Here you are #24 |
|
Please rebase and fix the comments that should be fixed (if any pending) |
chienandalu
force-pushed
the
10.0-l10n_de_steuernummer
branch
from
5aab698
to
e0fd2cd
Compare
|
@chienandalu @cubells give then your final blessing for merging. |
|
@pedrobaeza It still skips building runbot 😕 |
|
But it's because you haven't rebased properly. Check the .travis.yml in the branch: https://github.com/Tecnativa/l10n-germany/blob/10.0-l10n_de_steuernummer/.travis.yml |
chienandalu
force-pushed
the
10.0-l10n_de_steuernummer
branch
from
e0fd2cd
to
aacce0c
Compare
Following #17, this is the migration to 10.0 of the module still in PR. The discussion ended that this can be useful and should be merged, but it has not done it yet. We can move forward to this version now, as the customer is moving to this version.