-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] l10n_de_location_nuts: Migration to 12.0 #47
[MIG] l10n_de_location_nuts: Migration to 12.0 #47
Conversation
Hey @Tardo, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
? |
Please include |
@@ -0,0 +1,3 @@ | |||
To install this addon, you need 'requests' python module: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These instructions can be removed, as requests
is directly an Odoo requirement.
Please fix this |
4e635f7
to
62298af
Compare
Changes done, waiting for 'l10n_de_country_states'... |
You can rebase now. |
Must merge OCA/partner-contact#233 before to work.
* Hook for setting Germany country * Spanish translation fixes * Use separate and explicit fields for each NUTS level
62298af
to
d7ce6be
Compare
Done |
Great, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the work 👍
I did a code review: LGTM
just a minor change:
d7ce6be
to
a66fa20
Compare
Normal migration
Depends on this PR: #46