Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] l10n_de_location_nuts: Migration to 12.0 #47

Merged
merged 7 commits into from
May 19, 2019

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented May 16, 2019

Normal migration

Depends on this PR: #46

@oca-clabot
Copy link

Hey @Tardo, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@Tardo Tardo changed the title [MIG] l10n_de_location_nuts [MIG] l10n_de_location_nuts: Migration to 12.0 May 16, 2019
@Tardo Tardo closed this May 16, 2019
@pedrobaeza
Copy link
Member

?

@Tardo Tardo reopened this May 17, 2019
@pedrobaeza pedrobaeza added this to the 12.0 milestone May 17, 2019
@pedrobaeza
Copy link
Member

Please include oca_dependencies.txt file with partner-contact repo

@@ -0,0 +1,3 @@
To install this addon, you need 'requests' python module:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instructions can be removed, as requests is directly an Odoo requirement.

@pedrobaeza
Copy link
Member

Please fix this

@Tardo Tardo force-pushed the 12.0-mig-l10n_de_location_nuts branch from 4e635f7 to 62298af Compare May 19, 2019 19:59
@Tardo
Copy link
Member Author

Tardo commented May 19, 2019

Changes done, waiting for 'l10n_de_country_states'...

@OCA-git-bot OCA-git-bot mentioned this pull request May 19, 2019
5 tasks
@pedrobaeza
Copy link
Member

You can rebase now.

@Tardo Tardo force-pushed the 12.0-mig-l10n_de_location_nuts branch from 62298af to d7ce6be Compare May 19, 2019 22:26
@Tardo
Copy link
Member Author

Tardo commented May 19, 2019

Done

@pedrobaeza
Copy link
Member

Great, thanks.

@pedrobaeza pedrobaeza requested a review from tbaden May 19, 2019 22:39
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review: LGTM
just a minor change:

l10n_de_location_nuts/__manifest__.py Outdated Show resolved Hide resolved
@Tardo Tardo force-pushed the 12.0-mig-l10n_de_location_nuts branch from d7ce6be to a66fa20 Compare May 19, 2019 23:03
@pedrobaeza pedrobaeza merged commit 872f030 into OCA:12.0 May 19, 2019
@pedrobaeza pedrobaeza deleted the 12.0-mig-l10n_de_location_nuts branch May 19, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants