Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 mig l10n de skr03 mis reports #57

Closed

Conversation

OSevangelist
Copy link
Contributor

MIgration of Module

tv-openbig and others added 4 commits September 9, 2019 22:45
This module uses mis_report and adds the balance sheet and P&L report
for Germany. We need to do the same for l10n_de_skr04.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-germany-11.0/l10n-germany-11.0-l10n_de_skr03_mis_reports
Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-11-0/l10n-germany-11-0-l10n_de_skr03_mis_reports/
@OSevangelist
Copy link
Contributor Author

@fkantelberg can you please review what goes wrong with my PR and the check and why it exactly fails. Runbot says something with the mis_builder but that module already exists in v12

@fkantelberg
Copy link
Member

@OSevangelist
The misbuilder module moved to OCA/mis-builder which means you have to update the file oca_dependencies.txt in the root of the repository. The CI is loading it to check which further OCA repos he has to include. You should also keep care of the comment in the manifest.

@OSevangelist
Copy link
Contributor Author

@fkantelberg fixed one issue and directly got the next. It has to do with the country states but i have no clue how this could potentially go wrong. Any idea

@fkantelberg
Copy link
Member

@OSevangelist This one is weird and I don't see any hint in the code why this would even happen except that the previous installation went a bit wrong. I would suggest a debugging in the container. Check out this It looks like some remnants and you can recreate the database.

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 18, 2019
5 tasks
Copy link
Member

@daramousk daramousk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for this,

I think that travis is broken here, can you please make a separate commit over here that changes the .travis file to look like the one here https://github.com/OCA/maintainer-quality-tools/blob/master/sample_files/.travis.yml (follow the instructions there as well.

We need to make sure that travis works.

@@ -0,0 +1,25 @@
# -*- coding: utf-8 -*-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the encodings from all your *.py files.

@marylla
Copy link

marylla commented Jan 13, 2020

Hi @OSevangelist,
could you solve the problem?

@OSevangelist
Copy link
Contributor Author

@fkantelberg would please be so kind and help me on getting rid of he Runbot and Travis errors here once again. It seems that i am not the only person on this repository having these issues. In order to keep up a bit and improve the status of the German localisation it would be nice if we resolved the issues one by one

@fkantelberg
Copy link
Member

@OSevangelist
Yeah no wonder the country states are defined twice. Once in the module l10n_de_country_states and once in the l10n_de module. See https://github.com/OCA/OCB/blob/12.0/addons/l10n_de/data/res.country.state.csv but this file is only in version 12. Which makes the module l10n_de_country_states deprecated BUT the country states aren't ported to v13+ yet in base odoo.

@github-actions
Copy link

github-actions bot commented May 8, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 8, 2022
@marylla
Copy link

marylla commented Jun 3, 2022

@fkantelberg Can you please re-check this PR?

@fkantelberg
Copy link
Member

@marylla Nothing has changed in the 12.0 branch which means he would still fail. Technically the errors have nothing to do with this MR and #98 wanted to take care of it. I think we can follow the advice there and make the l10n_de_country_states uninstallable for 12.0

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 9, 2022
@github-actions github-actions bot closed this Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants