Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porting alla v8 "as-is" di account_vat_period_end_statement #105

Closed
wants to merge 6 commits into from

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Apr 9, 2015

TODO

...

@coveralls
Copy link

Coverage Status

Coverage decreased (-29.74%) to 38.42% when pulling 2d579c6 on andrea4ever:8.0-fix-issues75 into 5258f20 on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-27.72%) to 40.44% when pulling 3161e89 on andrea4ever:8.0-fix-issues75 into 5258f20 on OCA:8.0.

@tafaRU
Copy link
Member

tafaRU commented Apr 27, 2015

Travis build says:

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

Someone of maintainers could please restart the travis build?

Thank you in advance.

@tafaRU
Copy link
Member

tafaRU commented May 4, 2015

@andrea4ever, could you please confirm whether the points in TO DO list are completed? I am referring in particular to the latter.

Thank you in advance.

@andrea4ever
Copy link
Contributor

@tafaRU all points in TO DO are solved!

@tafaRU
Copy link
Member

tafaRU commented May 4, 2015

@andrea4ever thanks a lot!

@tafaRU
Copy link
Member

tafaRU commented May 4, 2015

@andrea4ever I see your branch is 48 commits behind OCA:8.0. Could you please rebase on it?

Thank you in advance.

@andrea4ever
Copy link
Contributor

@tafaRU Rebase Ok for me, can you check?

@eLBati
Copy link
Member Author

eLBati commented May 5, 2015

@andrea4ever did you include every more recent change from 7.0 version of account_vat_period_end_statement, or just the remove.period.from.vat.statement one? Could you indicate the commit(s) where this is done?
Thanks

@andrea4ever
Copy link
Contributor

@eLBati in this commit 0ac6a90, andrea4ever@0ac6a90

@tafaRU
Copy link
Member

tafaRU commented May 5, 2015

@andrea4ever rebase LGTM, the travis error seems not related to it, thanks!

@tafaRU
Copy link
Member

tafaRU commented May 8, 2015

@andrea4ever testando il branch ci siamo accorti di un errore a questa riga: https://github.com/OCA/l10n-italy/pull/105/files#diff-99ee513335d65d4ac645e350b767267dR115 (manca uno spazio che manda in errore la query).

Visto che non è possibile vedere il diff con la versione precedente ho preferito partire da una soluzione pulita e creare #108

Chiuderei pertanto la corrente, grazie!

@andrea4ever
Copy link
Contributor

@tafaRU ok!

@tafaRU
Copy link
Member

tafaRU commented May 8, 2015

Superseded by #108

@tafaRU tafaRU closed this May 8, 2015
OpenCode pushed a commit to OpenCode/l10n-italy that referenced this pull request May 9, 2017
patrickt-oforce pushed a commit to patrickt-oforce/l10n-italy that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants