Fix period for customer invoice #106

sergiocorato · 2015-04-09T09:38:15Z

For supplier invoices the existing code is correct.
For customer invoices, the period has to be taken from date of invoice and after, if missing, from registration date.

oca-clabot · 2015-04-09T09:38:17Z

Hey @sergiocorato, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@sergiocorato (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

eLBati · 2015-04-13T09:46:42Z

Hello @sergiocorato
I don't think inv.date_invoice can be empty after calling

super(AccountInvoice, self).action_move_create(
            cr, uid, ids, context=context)

Moreover, this would cause account.move and account.move.line to have incoherent date and period_id, doesn't it?

sergiocorato · 2015-04-13T20:01:41Z

Hello @eLBati
I didn't meant to say that the date_invoice is null (the code is unchanged in that part).
My commit is for another reason:

when I register a supplier invoice, VAT has to be calculated from the registration date period
when I register a customer invoice, VAT has to be calculated from the emission date period
Anyway, it's not common that a customer invoice is registered in a different date than the emission date, so is not a so worrying bug.

eLBati · 2015-04-14T06:12:19Z

For instance using this line

date_start = inv.date_invoice or inv.registration_date or time.strftime('%Y-%m-%d')

implies that, as inv.date_invoice can't be empty, date_start will always be = inv.date_invoice.
Thus, if inv.registration_date is not empty, period_id is retrieved using date_invoice, but mov_date using reg_date, that is = inv.registration_date.

So, period_id and date of account.move would be incoherent.

sergiocorato · 2015-04-16T15:00:20Z

Perhaps our VAT law is incoherent, but we must comply to it.

lepistone · 2015-07-02T06:41:44Z

account_invoice_entry_date/models/account.py

-                or time.strftime('%Y-%m-%d')
+            if inv.type in ['in_invoice', 'in_refund']:
+                date_start = inv.registration_date or inv.date_invoice \
+                    or time.strftime('%Y-%m-%d')


could you please define a variable today = time.strftime('%Y-%m-%d')?

oca-clabot · 2015-07-02T14:54:31Z

Hey @sergiocorato,
We acknowledge that the following users have signed our Contributor License Agreement:

@sergiocorato

Appreciation of efforts,
OCA CLAbot

sergiocorato · 2015-07-02T14:56:30Z

done, thanks

eLBati · 2015-07-03T10:43:30Z

Sorry, @sergiocorato I just tried to better understand the PR but I can't see what this change solves

the period has to be taken from date of invoice and after, if missing, from registration date

What do you mean with if missing? invoice date can't be missing.
Maybe could you describe the use case this changes solves?

sergiocorato · 2015-07-03T13:11:56Z

Hi @eLBati, the use case is from dpr 633/72 art. 1. Il contribuente deve annotare entro quindici giorni le fatture emesse, nell'ordine della loro numerazione e con riferimento alla data della loro emissione, in apposito registro.
So emission date have to be taken to select period, not registration date or today, if there is. If can't be missing, I can remove "or inv.registration_date or today" completely.

eLBati · 2015-07-04T08:54:25Z

With use case I mean something like

I create an invoice with date ...
I confirm invoice ...
Observed behavior: ...
Expected behavior: ...

sergiocorato · 2015-07-05T14:42:08Z

I have an user which register some invoices on 1° of month with last day of previous month date, so VAT registries are wrong because invoices go in the month of registration.

eLBati · 2015-07-06T17:36:29Z

I have an user which register some invoices on 1° of month with last day of previous month date, so VAT registries are wrong because invoices go in the month of registration

On http://2948683-8-0-2b230f.runbot2.odoo-community.org/ just created SAJ/2015/006, set Invoice Date = 2015-06-30, added one line and confirmed.
Entry date is correct: I am not able to reproduce the error

sergiocorato · 2015-07-06T19:46:12Z

Sorry the misunderstanding, the problem is the period (taxes are based on period, not on dates). I created SAJ/2015/007 with registration date 6th July and emission date 30th Juin, period is wrong (7th).

eLBati · 2015-07-09T14:32:19Z

On 6 July 2015 at 21:46, Sergio Corato notifications@github.com wrote:

Sorry the misunderstanding, the problem is the period (taxes are based on
period, not on dates). I created SAJ/2015/007 with registration date 6th
July and emission date 30th Juin, period is wrong (7th).

So, in this case, why do you fill the 'registration date' field?
Why don't you leave it empty?

Probably we should make the 'registration date' field visible for supplier
invoices only.

sergiocorato · 2015-07-09T14:44:19Z

All is possible, but it's legally register a customer invoice within 15
days from the emission, so if this field is hidden it would create a
missing legal feature.

Sergio Corato
Product Manager
SimplERP srl
tel. +390498597240
fax +390498596066

2015-07-09 16:32 GMT+02:00 Lorenzo Battistini notifications@github.com:

On 6 July 2015 at 21:46, Sergio Corato notifications@github.com wrote:

Sorry the misunderstanding, the problem is the period (taxes are based on
period, not on dates). I created SAJ/2015/007 with registration date 6th
July and emission date 30th Juin, period is wrong (7th).

So, in this case, why do you fill the 'registration date' field?
Why don't you leave it empty?

Probably we should make the 'registration date' field visible for supplier
invoices only.

—
Reply to this email directly or view it on GitHub
#106 (comment).

eLBati · 2015-07-09T14:58:34Z

Please answer my questions

sergiocorato · 2015-07-09T15:28:16Z

I leave it empty always, but some users could want to do that (even if I think it's an ugly practice)

eLBati · 2015-07-15T14:39:02Z

On 9 July 2015 at 17:28, Sergio Corato notifications@github.com wrote:

I leave it empty always, but some users could want to do that (even if I
think it's an ugly practice)

This is why I propose to make the 'registration date' field visible for
supplier invoices only.
I think it would make everything more simple.
What do you think?

sergiocorato · 2015-07-15T19:56:52Z

Yes, I think it's better for a simpler usage too.

2015-07-15 16:39 GMT+02:00 Lorenzo Battistini notifications@github.com:

On 9 July 2015 at 17:28, Sergio Corato notifications@github.com wrote:

I leave it empty always, but some users could want to do that (even if I
think it's an ugly practice)

This is why I propose to make the 'registration date' field visible for
supplier invoices only.
I think it would make everything more simple.
What do you think?

—
Reply to this email directly or view it on GitHub
#106 (comment).

supplier invoices only. See OCA#106 (comment)

eLBati · 2015-07-16T07:13:19Z

Here we are #123

…migr Migration of stock_picking_deliver_uos

supplier invoices only. See OCA/l10n-italy#106 (comment)

…_base [REM][intrastat_base] remove because this pr https://github.com/OCA/i…

Fix period for customer invoice

9ba720f

eLBati added needs review 8.0 labels Apr 13, 2015

lepistone reviewed Jul 2, 2015
View reviewed changes

put today variable

8916fbf

eLBati added a commit to eLBati/l10n-italy that referenced this pull request Jul 16, 2015

[FIX] making the 'registration date' field visible for

e6e4e4d

supplier invoices only. See OCA#106 (comment)

eLBati mentioned this pull request Jul 16, 2015

[FIX] making the 'registration date' field visible for #123

Merged

sergiocorato closed this Jul 23, 2015

yvaucher removed the needs review label Jul 23, 2015

OpenCode pushed a commit to OpenCode/l10n-italy that referenced this pull request May 9, 2017

Merge pull request OCA#106 from tafaRU/8.0-stock_picking_deliver_uos-…

e8eeef0

…migr Migration of stock_picking_deliver_uos

RodrigoBM pushed a commit to factorlibre/l10n-spain that referenced this pull request Oct 11, 2021

[FIX] making the 'registration date' field visible for

e7e7995

supplier invoices only. See OCA/l10n-italy#106 (comment)

patrickt-oforce pushed a commit to patrickt-oforce/l10n-italy that referenced this pull request Jul 11, 2023

Merge pull request OCA#106 from openforceit/12.0-XXXX-remove_instrast…

fb3ada2

…_base [REM][intrastat_base] remove because this pr https://github.com/OCA/i…

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix period for customer invoice #106

Fix period for customer invoice #106

sergiocorato commented Apr 9, 2015

oca-clabot commented Apr 9, 2015

eLBati commented Apr 13, 2015

sergiocorato commented Apr 13, 2015

eLBati commented Apr 14, 2015

sergiocorato commented Apr 16, 2015

lepistone Jul 2, 2015

oca-clabot commented Jul 2, 2015

sergiocorato commented Jul 2, 2015

eLBati commented Jul 3, 2015

sergiocorato commented Jul 3, 2015

eLBati commented Jul 4, 2015

sergiocorato commented Jul 5, 2015

eLBati commented Jul 6, 2015

sergiocorato commented Jul 6, 2015

eLBati commented Jul 9, 2015

sergiocorato commented Jul 9, 2015

eLBati commented Jul 9, 2015 via email

sergiocorato commented Jul 9, 2015

eLBati commented Jul 15, 2015

sergiocorato commented Jul 15, 2015

eLBati commented Jul 16, 2015

Fix period for customer invoice #106

Fix period for customer invoice #106

Conversation

sergiocorato commented Apr 9, 2015

oca-clabot commented Apr 9, 2015

eLBati commented Apr 13, 2015

sergiocorato commented Apr 13, 2015

eLBati commented Apr 14, 2015

sergiocorato commented Apr 16, 2015

lepistone Jul 2, 2015

Choose a reason for hiding this comment

oca-clabot commented Jul 2, 2015

sergiocorato commented Jul 2, 2015

eLBati commented Jul 3, 2015

sergiocorato commented Jul 3, 2015

eLBati commented Jul 4, 2015

sergiocorato commented Jul 5, 2015

eLBati commented Jul 6, 2015

sergiocorato commented Jul 6, 2015

eLBati commented Jul 9, 2015

sergiocorato commented Jul 9, 2015

eLBati commented Jul 9, 2015 via email

sergiocorato commented Jul 9, 2015

eLBati commented Jul 15, 2015

sergiocorato commented Jul 15, 2015

eLBati commented Jul 16, 2015