Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] [FIX][l10n_it_account] Fix: better management of account_balance_sign… #1585

Merged
merged 2 commits into from
Jan 14, 2020
Merged

[12.0] [FIX][l10n_it_account] Fix: better management of account_balance_sign… #1585

merged 2 commits into from
Jan 14, 2020

Conversation

SilvioGregorini
Copy link
Contributor

…s upon account types and account groups

Collegato a #1583

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@eLBati eLBati changed the title [FIX][l10n_it_account] Fix: better management of account_balance_sign… [12.0] [FIX][l10n_it_account] Fix: better management of account_balance_sign… Jan 9, 2020
eLBati
eLBati approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie!

Riesci mica ad aggiungere un test per coprire anche quando effettivamente ci sono padri e segni
https://codecov.io/gh/OCA/l10n-italy/compare/65a57c9e6335773fb1309ddbcadd683aa9719ce1...68a425d113e6b6b14a45eb6a5876ba0e63987d0f/diff
?

@SilvioGregorini SilvioGregorini mentioned this pull request Jan 9, 2020
Closed
2 tasks
@SilvioGregorini
Copy link
Contributor Author

@eLBati non mi è ben chiaro cosa dovrei fare, relativamente ai test...

@eLBati
Copy link
Member

eLBati commented Jan 10, 2020

@SilvioGregorini mancherebbe un test per get_account_balance_sign.
Comunque non avevo visto che have_same_sign è coperto, quindi decidi tu se aumentare la copertura a get_account_balance_sign o fare merge così com'è

eLBati
eLBati requested changes Jan 13, 2020
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah però in questo momento non si può installare l10n_it_account su un DB con i conti già creati: SilvioGregorini#1

@eLBati eLBati mentioned this pull request Jan 13, 2020
Merged
@SilvioGregorini
Copy link
Contributor Author

@eLBati grazie della PR, non mi ero accorto che ci fosse il blocco.
Devo risistemare la commit history squashando il commit di merge, o lascio così?

@eLBati
Copy link
Member

eLBati commented Jan 13, 2020

@SilvioGregorini potresti rimuovere il commit di merge con un rebase (non so se ocabot lo faccia)

SilvioGregorini and others added 2 commits January 13, 2020 12:11
@SilvioGregorini
[FIX][l10n_it_account] Fix: better management of account_balance_sign…
60e25ac 
…s upon account types and account groups
@eLBati @SilvioGregorini
Skip sign check in module init and migration, fixing the case of modu…
75a1cc5 
…le installation when accounts are already created (otherwise installation is blocked)
@SilvioGregorini SilvioGregorini force-pushed the 12.0-FIX-l10n_it_account_balance_signs branch from 50220c2 to 75a1cc5 Compare January 13, 2020 11:12
@SilvioGregorini
Copy link
Contributor Author

@eLBati fatto 👍

eLBati
eLBati approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@eLBati
Copy link
Member

eLBati commented Jan 14, 2020

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-1585-by-eLBati-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 14, 2020
@OCA-git-bot
Merge PR #1585 into 12.0
c392efa 
Signed-off-by eLBati
@OCA-git-bot OCA-git-bot merged commit 75a1cc5 into OCA:12.0 Jan 14, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 231fc65. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot changed the title [12.0] [FIX][l10n_it_account] Fix: better management of account_balance_sign… [12.0] [FIX][l10n_it_account] Fix: better management of account_balance_sign… Jan 14, 2020
@SilvioGregorini SilvioGregorini deleted the 12.0-FIX-l10n_it_account_balance_signs branch January 14, 2020 09:32
@sergiocorato sergiocorato mentioned this pull request Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati approved these changes

@alessandrocamilli alessandrocamilli alessandrocamilli approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SilvioGregorini @eLBati @OCA-git-bot @alessandrocamilli