Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] FIX fatturapa_in regex pattern, add pec_destinatario/codice_destinatario cross check #1598

Closed
wants to merge 3 commits into from

Conversation

primes2h
Copy link
Contributor

@primes2h primes2h commented Jan 18, 2020

Fix #1131 + #1189 + #922 + adapt modules name to italian guidelines.

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

sergiocorato and others added 3 commits January 18, 2020 19:32
[FIX] remove escape sequence from . used for file extension separation

[FIX] escape . used for file extension separation
 * Fix FATTURAPA_IN_REGEX to allow signed incoming invoices.
…destinatario

and check empty codice_destinatario
@primes2h
Copy link
Contributor Author

primes2h commented Jan 18, 2020

Scusate, mi sono appena accorto che c'era già una PR aperta #1179 ma non l'avevo vista perché non è tracciata nella issue #1189
È anche vero che sembra abbondonata. (@glauco70 ?)

P.S.: la PR che ho aperto aggiunge anche il fix #1131.

@primes2h primes2h requested review from eLBati, SimoRubi, taifu and tafaRU and removed request for eLBati, SimoRubi and taifu January 18, 2020 19:54
Copy link

@marcelofrare marcelofrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ho testato in locale con un db pulito e un messaggio con file *.xml.p7m.
Ha scaricato correttamente il file. (prima della modifica non lo scaricava)

Ho verificato inoltre la corretta compilazione del campo "codice destinatario" con sette zeri di default. Se lo cambio, nasconde il campo PEC

Grazie @primes2h!

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 11, 2022
@github-actions github-actions bot closed this Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants