Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] l10n_it_ddt: fix invoice generation #1606

Merged

Conversation

SimoRubi
Copy link
Member

Descrizione del problema o della funzionalità
Fix nella creazione delle fatture da DDT multipli + refactor (commit separato)

Comportamento attuale prima di questa PR
Durante la creazione delle fatture da diversi DDT, alcune righe di un DDT potrebbero risultare ad un'altra fattura creata precedentemente.

Comportamento desiderato dopo questa PR
Tutte le righe dello stesso DDT sono raccolte nella stessa fattura.

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@eLBati
Copy link
Member

eLBati commented Jan 22, 2020

@SimoRubi potresti creare la issue con i passi per riprodurre?

Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per il resto LGTM.
Grazie!

l10n_it_ddt/models/partner.py Show resolved Hide resolved
@SimoRubi
Copy link
Member Author

@SimoRubi potresti creare la issue con i passi per riprodurre?

Ho provato a riprodurre l'errore con un test automatico ma non sono riuscito perché non conosco i passi per arrivare alla situazione che poi porta l'errore, quando posso mi ci metto.

@SimoRubi
Copy link
Member Author

SimoRubi commented Feb 4, 2020

@eLBati l'ordine dei commit qui su Github è quel che è, comunque ho 3 commit in questa PR:

  1. Aggiungo un test, che fallisce
  2. Fix per il test
  3. Refactoring

E qui c'è la issue: #1622

Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimoRubi
Copy link
Member Author

@tafaRU puoi aggiornare la tua review? Così se anche per te è ok, potremmo andare avanti con il merge

@SimoRubi SimoRubi force-pushed the 12.0-l10n_it_ddt-fix_invoice_generation branch from 51032db to 569b36f Compare February 10, 2020 16:11
@SimoRubi SimoRubi requested a review from tafaRU February 10, 2020 16:11
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@SimoRubi
Copy link
Member Author

@OCA/local-italy-maintainers che dite si può procedere al merge o devo fare altre modifiche? Grazie

@eLBati
Copy link
Member

eLBati commented Feb 14, 2020

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-1606-by-eLBati-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 14, 2020
Signed-off-by eLBati
@OCA-git-bot OCA-git-bot merged commit 569b36f into OCA:12.0 Feb 14, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9c99e7d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants