Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] mig l10n_it_fatturapa_out #663

Merged
merged 76 commits into from
Dec 8, 2018

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Nov 16, 2018

Depends on #662

TODO
#691
#693
#694
#699
#700
#702

@eLBati eLBati added this to the 12.0 milestone Nov 16, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 16, 2018
35 tasks
@eLBati eLBati force-pushed the 12.0-mig-l10n_it_fatturapa_out branch 2 times, most recently from 409acea to b7125c4 Compare November 21, 2018 21:59
@primes2h
Copy link
Contributor

Aperta la PR #674 da includere.

@eLBati
Copy link
Member Author

eLBati commented Nov 27, 2018

@primes2h grazie, incluso 365ed89

@primes2h
Copy link
Contributor

primes2h commented Dec 5, 2018

Functional test:

  • Create a new invoice
  • Validate the invoice
  • Click on "Export E-invoice"

You get the error
"Company does not have fiscal code or VAT number."
despite company VAT number has been set for the company.

@eLBati eLBati force-pushed the 12.0-mig-l10n_it_fatturapa_out branch from c460a52 to d08a0d6 Compare December 5, 2018 22:05
@eLBati
Copy link
Member Author

eLBati commented Dec 6, 2018

@primes2h I can't reproduce the error.
Consider that here 'company' is your company.

@primes2h
Copy link
Contributor

primes2h commented Dec 6, 2018

@primes2h I can't reproduce the error.
Consider that here 'company' is your company.

Ok, it's official. I need a break. 😓

@eLBati
Copy link
Member Author

eLBati commented Dec 6, 2018

@primes2h 😁 do you think message should be improved with "your company"?

@primes2h
Copy link
Contributor

primes2h commented Dec 6, 2018

@primes2h do you think message should be improved with "your company"?

In fact it's seems to be the Odoo standard, a lot of strings use that form. Make them uniform could be an improvement.

Nevertheless it was my fault, difference between company and partner is clear. 😛

@eLBati eLBati force-pushed the 12.0-mig-l10n_it_fatturapa_out branch 4 times, most recently from e5d38f4 to 8aa1b13 Compare December 7, 2018 17:34
hurrinico and others added 11 commits December 7, 2018 21:38
[FIX] base porting

[FIX] wrong menu

[FIX] fix province

[FIX] Manage ascii error

[FIX] Fix pep8
[FIX] unidecode instead of normalize

[FIX] change toxml
[ADD] handle 0 tax rate
[DEL] no need to validate schema. pyxb does it

[FIX] missing file

[DEL] old methods

[FIX] tests

[ADD] contatti

[ADD] TipoDocumento

[ADD] setDatiPagamento

[IMP] description

[FIX] images

[FIX] tests with payments

[ADD] test with related docs

[ADD] related docs tests

[FIX] payment term tests

[FIX] set REA data

[IMP] description, help and error strings

[ADD] security

[ADD] Causale

[ADD] payability management

[FIX] export multiline comment

[FIX] handle missing law reference

[FIX] handle
Type {http://www.fatturapa.gov.it/sdi/fatturapa/v1.1}String1000LatinType cannot be created from {http://www.fatturapa.gov.it/sdi/fatturapa/v1.1}String1000LatinType: Service\n2

Conflicts:
	l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py

[ADD] porting 7.0 changes to 8.0

[FIX] tests
[FIX] Remove restricted from fatturapa_attachment_out_id
[FIX] xml demo data
[IMP] new xml demo data fatturaPA with attachment
[IMP] new xml file to check export wizard
[IMP] handle related attachment in wizard export FatturaPA
[IMP] tests export with attachments
[FIX] Flake8

[IMP] handle fiscalyear for test

[FIX] remove useless print
[ADD] comment in method

[FIX] comment
    'external_dependencies': {
        'python': ['unidecode'],
    }
eLBati and others added 27 commits December 7, 2018 21:38
l10n_it_fatturapa_in to 10
(REF withholding tax integration, invoice interface, fiscal document type
ADD some DatiGeneraliDocumento fields)
ADD _setTerzoIntermediarioOSoggettoEmittente to l10n_it_fatturapa_out
ADD PECDestinatario, CodiceDestinatario , FormatoTrasmissione handling
ADD Lotto di fatture verso soggetto privato
ADD gestione prodotti nelle fatture passive
ADD l10n_it_fatturapa_in_purchase
ADD einvoice.line model
IMP form fatture
ADD Livello di dettaglio Fatture elettroniche
ADD PDF preview dell'XML
ADD Link to existing supplier invoice
and handle "registered" XML
ADD rappresentante fiscale e stabile organizzazione in emissione
gestione prodotti DatiBollo , DatiCassaPrevidenziale e ScontoMaggiorazione
CodiceArticolo, ftpa_line_number

IMP "show preview" as link
FIX invoice duplication

ADD constraints and Nome Cognome

Avoid to cancel invoice with XML

Mostra i dati fattura elettronica solo se il cliente è soggetto
IMP READMEs

Gestione IVA inclusa nel prezzo

ADD l10n_it_fatturapa_out_ddt

IMP PEP8

IMP decimal precision
ADD Export E-invoice button
IMP README
Currently translated at 88.9% (80 of 90 strings)

Translation: l10n-italy-10.0/l10n-italy-10.0-l10n_it_fatturapa_out
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-10-0/l10n-italy-10-0-l10n_it_fatturapa_out/it/
[ADD] l10n_it_fatturapa_out: generate a report for invoice and include in generated XML

[FIX] l10n_it_fatturapa_out: attachments must be encoded only once
Currently translated at 88.9% (80 of 90 strings)

Translation: l10n-italy-10.0/l10n-italy-10.0-l10n_it_fatturapa_out
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-10-0/l10n-italy-10-0-l10n_it_fatturapa_out/it/
- Set 'Product Price' Decimal Accuracy with Digits = 4
 - Create an invoice with 1 line with quantity = 24 and price 1.2519
 - Export XML

In the XML you get
Quantità: 24.00
Valore unitario: 1.25
Valore totale: 30.05

While you should have
Valore unitario: 1.2519
Currently translated at 88.9% (80 of 90 strings)

Translation: l10n-italy-10.0/l10n-italy-10.0-l10n_it_fatturapa_out
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-10-0/l10n-italy-10-0-l10n_it_fatturapa_out/it/
…e a PDF attached in the Fattura Elettronica XML (OCA#643)

* [IMP] l10n_it_fatturapa_out: Add flag to recognize which invoices have a PDF attached in the Fattura Elettronica XML

* [FIX] l10n_it_fatturapa_out: Remove confirm label

* fixup! [FIX] l10n_it_fatturapa_out: Remove confirm label
FIX
Mail delivery failed via SMTP server 'smtps.pec.aruba.it'.
SMTPRecipientsRefused: {'agilebg@pec.it': (553, '5.7.1 <elbaddy+1-fatturapa.attachment.out-6@gmail.com>: Sender address rejected: not owned by user l.battistini@pec.it')}
Traceback (most recent call last):
  File "/home/elbati/workspace/odoo/instances/demo10-community/parts/odoo/addons/mail/models/mail_mail.py", line 278, in send
    res = IrMailServer.send_email(msg, mail_server_id=mail.mail_server_id.id)
  File "/home/elbati/workspace/odoo/instances/demo10-community/parts/odoo/odoo/addons/base/ir/ir_mail_server.py", line 467, in send_email
    raise MailDeliveryException(_("Mail Delivery Failed"), msg)
MailDeliveryException: (u'Mail Delivery Failed', u"Mail delivery failed via SMTP server 'smtps.pec.aruba.it'.\nSMTPRecipientsRefused: {'agilebg@pec.it': (553, '5.7.1 <elbaddy+1-fatturapa.attachment.out-6@gmail.com>: Sender address rejected: not owned by user l.battistini@pec.it')}")

ADD l10n_it_fatturapa_out: tracking attachment changes

IMP mail send: raise exception in case

Translated using Weblate (Italian)

Currently translated at 94.4% (85 of 90 strings)

Translation: l10n-italy-10.0/l10n-italy-10.0-l10n_it_fatturapa_out
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-10-0/l10n-italy-10-0-l10n_it_fatturapa_out/it/

IMP README
exceptions sending email
Avoid to delete sent files
Check duplicated files
Send several files
Reset to ready button
Sending and delivery date
Handling ACCETTAZIONE and CONSEGNA
IMP 'link to existing invoice' wizard
FIX invoice views within attachment view
IMP attachments views
IMP l10n_it_fatturapa_out export: allow multiple export , group by partner
ALLOW to use newline char in invoice line description
check sequence without date ranges
Extract correcttle messages from NS
Currently translated at 95.6% (86 of 90 strings)

Translation: l10n-italy-10.0/l10n-italy-10.0-l10n_it_fatturapa_out
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-10-0/l10n-italy-10-0-l10n_it_fatturapa_out/it/
Currently translated at 95.6% (86 of 90 strings)

Translation: l10n-italy-10.0/l10n-italy-10.0-l10n_it_fatturapa_out
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-10-0/l10n-italy-10-0-l10n_it_fatturapa_out/it/
[IMP] revamp README and manifest

[FIX] translation source strings l10n_it_fatturapa_out

Some strings depend on l10n_it_fatturapa/demo/account_invoice_fatturapa.xml fields

[FIX] l10n_it_fatturapa_out translation source strings
squash! FIX l10n_it_fatturapa: province is not required in XML
phone and email neither
* [10.0][FIX] l10n_it_fatturapa_out: Error sting encoding
@eLBati eLBati force-pushed the 12.0-mig-l10n_it_fatturapa_out branch from 8aa1b13 to 5d450d2 Compare December 7, 2018 20:38
Copy link
Contributor

@mrcast mrcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test ok
Thanks

@eLBati eLBati merged commit 95fbe2a into OCA:12.0 Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet