-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] mail_pec field in list and kanban view #71
Conversation
@@ -0,0 +1,16 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file should not be there
👍 |
@archetipo I noticed that indentantion in xml file is mixed: you are using both 2 and 4 spaces. Thank you in advance. |
thanks @archetipo, now LGTM so 👍 |
👍 |
<field name="arch" type="xml"> | ||
<field name="email" position="after"> | ||
<field name="pec_mail"/> | ||
</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong here..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeartS is right, @archetipo you could please fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok .. I had not seen it thanks
@archetip, archetipo#10 fixes last indentation error. |
Fix indentation in res_partner_kanban_pec_view
I'm in favour of @LeartS' proposal. @archetipo and you? |
De gustibus non disputandum est .. |
@archetipo here is the PR archetipo#11 |
[IMP] the bold text is really out of place
[IMP] mail_pec field in list and kanban view
Porting ftpa out 8 to7
8.0 fix shipment plan wkfl reset
No description provided.