Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mail_pec field in list and kanban view #71

Merged
merged 9 commits into from
Jan 8, 2015

Conversation

archetipo
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a450e0f on archetipo:imp_pec_view8 into 9f516e3 on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling f700f80 on archetipo:imp_pec_view8 into 9f516e3 on OCA:8.0.

@@ -0,0 +1,16 @@
#!/bin/sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file should not be there

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 00ecafd on archetipo:imp_pec_view8 into 9f516e3 on OCA:8.0.

@eLBati
Copy link
Member

eLBati commented Dec 18, 2014

👍

@tafaRU
Copy link
Member

tafaRU commented Dec 18, 2014

@archetipo I noticed that indentantion in xml file is mixed: you are using both 2 and 4 spaces.
Could you please get indentantion uniform?

Thank you in advance.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a4f37ce on archetipo:imp_pec_view8 into 9f516e3 on OCA:8.0.

@tafaRU
Copy link
Member

tafaRU commented Dec 18, 2014

thanks @archetipo, now LGTM so 👍

@dcorio
Copy link
Contributor

dcorio commented Dec 18, 2014

👍

<field name="arch" type="xml">
<field name="email" position="after">
<field name="pec_mail"/>
</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong here..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeartS is right, @archetipo you could please fix it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok .. I had not seen it thanks

@tafaRU
Copy link
Member

tafaRU commented Dec 19, 2014

@archetip, archetipo#10 fixes last indentation error.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 02ccf4b on archetipo:imp_pec_view8 into 9f516e3 on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ffeaccb on archetipo:imp_pec_view8 into 9f516e3 on OCA:8.0.

@LeartS
Copy link
Contributor

LeartS commented Dec 19, 2014

👍
A minor detail: I've installed the module and noticed that the bold text is really out of place:
current
I propose this alternative:
alternative

@tafaRU
Copy link
Member

tafaRU commented Dec 19, 2014

I'm in favour of @LeartS' proposal. @archetipo and you?

@archetipo
Copy link
Member Author

De gustibus non disputandum est ..
tell me...

@eLBati
Copy link
Member

eLBati commented Jan 8, 2015

@archetipo here is the PR archetipo#11

[IMP] the bold text is really out of place
tafaRU added a commit that referenced this pull request Jan 8, 2015
[IMP] mail_pec field in list and kanban view
@tafaRU tafaRU merged commit ec71a2f into OCA:8.0 Jan 8, 2015
eLBati added a commit to archetipo/l10n-italy that referenced this pull request Aug 26, 2015
OpenCode pushed a commit to OpenCode/l10n-italy that referenced this pull request May 9, 2017
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Jan 13, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Jan 14, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Jan 14, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Feb 2, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Mar 2, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Mar 2, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Mar 2, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Mar 2, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Mar 2, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Mar 23, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Jul 27, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Jul 27, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Jul 27, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Jul 27, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Jul 28, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Aug 27, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Aug 27, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Sep 3, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Sep 24, 2021
SimoneVagile pushed a commit to SimoneVagile/l10n-italy that referenced this pull request Nov 2, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Nov 2, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Nov 20, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Dec 3, 2021
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Nov 18, 2022
Borruso added a commit to Borruso/l10n-italy that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants