Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] l10n_it_fatturapa_out_stamp #778

Merged
merged 4 commits into from Feb 7, 2019
Merged

[11.0][MIG] l10n_it_fatturapa_out_stamp #778

merged 4 commits into from Feb 7, 2019

Conversation

SimoRubi
Copy link
Member

@SimoRubi SimoRubi commented Jan 4, 2019

Standard migration, depends on #777

@SimoRubi SimoRubi force-pushed the 11.0-mig-l10n_it_fatturapa_out_stamp branch from d808e94 to da28f57 Compare January 4, 2019 13:51
@SimoRubi SimoRubi changed the title [11.0[MIG] l10n_it_fatturapa_out_stamp [11.0][MIG] l10n_it_fatturapa_out_stamp Jan 4, 2019
@SimoRubi
Copy link
Member Author

SimoRubi commented Jan 4, 2019

#774 included

@SimoRubi SimoRubi force-pushed the 11.0-mig-l10n_it_fatturapa_out_stamp branch from fd5a097 to cc626cd Compare January 11, 2019 14:51
@SimoRubi SimoRubi force-pushed the 11.0-mig-l10n_it_fatturapa_out_stamp branch from cc626cd to 1632b76 Compare January 24, 2019 15:54
@SimoRubi
Copy link
Member Author

Rebased after #777

GSLabIt
GSLabIt approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@GSLabIt GSLabIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests LGTM

@SimoRubi
Copy link
Member Author

Thanks @joezsweet for the review

@SimoRubi
Copy link
Member Author

SimoRubi commented Feb 1, 2019

@OCA/local-italy-maintainers could you please check? Thanks

tafaRU
tafaRU approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimoRubi riesci a schiacciare i due commit relativi al pot?

@SimoRubi SimoRubi force-pushed the 11.0-mig-l10n_it_fatturapa_out_stamp branch from 1632b76 to 3610cfe Compare February 1, 2019 13:47
@SimoRubi
Copy link
Member Author

SimoRubi commented Feb 1, 2019

@tafaRU fatto

@tafaRU
Copy link
Member

tafaRU commented Feb 1, 2019

Grazie @SimoRubi

@primes2h
Copy link
Contributor

primes2h commented Feb 1, 2019 •
edited

@SimoRubi nella 11.0 sarebbe da includere anche questo commit 2448fa7 di l10n_it_account_stamp. È il caso di farlo qui?

@SimoRubi
Copy link
Member Author

SimoRubi commented Feb 1, 2019

@primes2h visto che questa PR è già pronta per essere mergiata (supponendo che Travis sia ✔️), creerei un'altra PR di allineamento con le varie versioni.

@primes2h
Copy link
Contributor

primes2h commented Feb 1, 2019

@primes2h visto che questa PR è già pronta per essere mergiata (supponendo che Travis sia heavy_check_mark), creerei un'altra PR di allineamento con le varie versioni.

👍

@SimoRubi
Copy link
Member Author

SimoRubi commented Feb 4, 2019

@OCA/local-italy-maintainers si può mergiare? Grazie

@eLBati eLBati merged commit b42aea0 into OCA:11.0 Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafaRU tafaRU tafaRU approved these changes

@GSLabIt GSLabIt GSLabIt approved these changes

@labaggio labaggio labaggio approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@SimoRubi @tafaRU @primes2h @GSLabIt @labaggio @eLBati @OCA-git-bot @oca-travis