New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0] IMP l10n_it_fatturapa_pec allowing to force the XML export state. #935
Conversation
1f70ea1
to
709f502
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried on runbot.
I exported an xml file and I was able to change its state.
I activated developer mode and I went on user (admin) configuration, but "force state" checkbox wasn't selected.
I went back to exported xml file and this time clicking on a state popped up the error message.
709f502
to
ede3bf3
Compare
@@ -10,7 +10,7 @@ | |||
<header> | |||
<button name="send_via_pec" states="ready" string="Send Via PEC" type="object" class="oe_highlight"/> | |||
<button name="reset_to_ready" states="sender_error" string="Reset to ready" type="object" /> | |||
<field name="state" widget="statusbar"/> | |||
<field name="state" widget="statusbar" clickable="1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non so se sia il caso di rendere gli stati "cliccabili" a prescindere dall'attivazione del flag.
La condizione di poter modificare lo stato è un'eccezione a un sistema di gestione automatico degli stati tramite messaggi PEC di notifica.
Forse un
attrs="{'clickable': [('e_inv_export_state_clickable', '=', True)]}"
sarebbe più indicato e semplificherebbe il tutto (non sarebbe più necessario il messaggio di errore).
O forse mi sfugge qualcosa nella logica di questa funzionalità aggiuntiva.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forse un
attrs="{'clickable': [('e_inv_export_state_clickable', '=', True)]}"
sarebbe più indicato e semplificherebbe il tutto (non sarebbe più necessario il messaggio di errore).
Concordo che lo sarebbe, però non mi pare che questo attrs
funzionerebbe, perchè e_inv_export_state_clickable
non è un campo ma un elemento del context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sto però provando un'altra implementazione
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forse un
attrs="{'clickable': [('e_inv_export_state_clickable', '=', True)]}"
sarebbe più indicato e semplificherebbe il tutto (non sarebbe più necessario il messaggio di errore).Concordo che lo sarebbe, però non mi pare che questo
attrs
funzionerebbe, perchèe_inv_export_state_clickable
non è un campo ma un elemento del context
Ho ancora tanto da imparare. 😅
dd42074
to
0f9b631
Compare
bd56c43
to
2393284
Compare
@@ -2,6 +2,10 @@ | |||
|
|||
Consultare il modulo `l10n_it_sdi_channel`. | |||
|
|||
Lo stato dell'esportazione XML può essere forzato assegnando all'utente il gruppo 'permetti di forzare lo stato dell'esportazione e-fattura'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essendo una casella di selezione relativa a una preferenza, secondo le linee guida andrebbe tradotta usando l'infinito presente.
Es.
Consentire/Permettere forzatura stato di esportazione e-fattura
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per il resto 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dimenticavo.
Nelle indicazioni di configurazione forse il concetto di gruppo dell'utente è più a livello tecnico che funzionale imho.
Per l'utente che installa il modulo abilitare la funzionalità consiste nel selezionare una casella che si trova nella configurazione utente.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@primes2h grazie, fatto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grazie. 👍
Only 'Allow to force e-invoice export state' group can
2393284
to
189e327
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (only technical review)
…A#935) Only 'Allow to force e-invoice export state' group can
Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
…A#935) Only 'Allow to force e-invoice export state' group can
Only 'Allow to force e-invoice export state' group can