Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] IMP l10n_it_fatturapa_pec allowing to force the XML export state. #935

Merged
merged 1 commit into from Feb 4, 2019

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Feb 1, 2019

Only 'Allow to force e-invoice export state' group can

@eLBati eLBati force-pushed the 12.0-allow-to-force-export-state branch from 1f70ea1 to 709f502 Compare February 1, 2019 14:02
Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried on runbot.
I exported an xml file and I was able to change its state.
I activated developer mode and I went on user (admin) configuration, but "force state" checkbox wasn't selected.
I went back to exported xml file and this time clicking on a state popped up the error message.

@eLBati eLBati force-pushed the 12.0-allow-to-force-export-state branch from 709f502 to ede3bf3 Compare February 1, 2019 15:05
@eLBati
Copy link
Member Author

eLBati commented Feb 1, 2019

@@ -10,7 +10,7 @@
<header>
<button name="send_via_pec" states="ready" string="Send Via PEC" type="object" class="oe_highlight"/>
<button name="reset_to_ready" states="sender_error" string="Reset to ready" type="object" />
<field name="state" widget="statusbar"/>
<field name="state" widget="statusbar" clickable="1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non so se sia il caso di rendere gli stati "cliccabili" a prescindere dall'attivazione del flag.
La condizione di poter modificare lo stato è un'eccezione a un sistema di gestione automatico degli stati tramite messaggi PEC di notifica.

Forse un
attrs="{'clickable': [('e_inv_export_state_clickable', '=', True)]}"
sarebbe più indicato e semplificherebbe il tutto (non sarebbe più necessario il messaggio di errore).

O forse mi sfugge qualcosa nella logica di questa funzionalità aggiuntiva.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forse un
attrs="{'clickable': [('e_inv_export_state_clickable', '=', True)]}"
sarebbe più indicato e semplificherebbe il tutto (non sarebbe più necessario il messaggio di errore).

Concordo che lo sarebbe, però non mi pare che questo attrs funzionerebbe, perchè e_inv_export_state_clickable non è un campo ma un elemento del context

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sto però provando un'altra implementazione

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forse un
attrs="{'clickable': [('e_inv_export_state_clickable', '=', True)]}"
sarebbe più indicato e semplificherebbe il tutto (non sarebbe più necessario il messaggio di errore).

Concordo che lo sarebbe, però non mi pare che questo attrs funzionerebbe, perchè e_inv_export_state_clickable non è un campo ma un elemento del context

Ho ancora tanto da imparare. 😅

@eLBati eLBati force-pushed the 12.0-allow-to-force-export-state branch 2 times, most recently from dd42074 to 0f9b631 Compare February 1, 2019 16:07
@eLBati
Copy link
Member Author

eLBati commented Feb 1, 2019

@primes2h @tafaRU caricata un'implementazione più pulita

@eLBati eLBati force-pushed the 12.0-allow-to-force-export-state branch 2 times, most recently from bd56c43 to 2393284 Compare February 1, 2019 17:11
@@ -2,6 +2,10 @@

Consultare il modulo `l10n_it_sdi_channel`.

Lo stato dell'esportazione XML può essere forzato assegnando all'utente il gruppo 'permetti di forzare lo stato dell'esportazione e-fattura'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essendo una casella di selezione relativa a una preferenza, secondo le linee guida andrebbe tradotta usando l'infinito presente.
Es.
Consentire/Permettere forzatura stato di esportazione e-fattura

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per il resto 👍

Copy link
Contributor

@primes2h primes2h Feb 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dimenticavo.
Nelle indicazioni di configurazione forse il concetto di gruppo dell'utente è più a livello tecnico che funzionale imho.
Per l'utente che installa il modulo abilitare la funzionalità consiste nel selezionare una casella che si trova nella configurazione utente.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@primes2h grazie, fatto.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie. 👍

Only 'Allow to force e-invoice export state' group can
@eLBati eLBati force-pushed the 12.0-allow-to-force-export-state branch from 2393284 to 189e327 Compare February 2, 2019 16:44
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (only technical review)

@eLBati eLBati merged commit 91750da into OCA:12.0 Feb 4, 2019
eLBati added a commit to eLBati/l10n-italy that referenced this pull request Feb 4, 2019
…A#935)

Only 'Allow to force e-invoice export state' group can
eLBati added a commit that referenced this pull request Feb 6, 2019
Only 'Allow to force e-invoice export state' group can
SimoRubi pushed a commit to SimoRubi/l10n-italy that referenced this pull request Aug 7, 2019
…of temporary errors. (OCA#914)

Retry N (configurable) times before resetting fetchmail server.
Notify contacts about reset

IMP l10n_it_fatturapa_pec allowing to force the XML export state. (OCA#935)

Only 'Allow to force e-invoice export state' group can
SimoRubi pushed a commit to SimoRubi/l10n-italy that referenced this pull request Aug 7, 2019
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Aug 9, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Sep 17, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 8, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 15, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 22, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Nov 2, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Nov 16, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Nov 20, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Dec 10, 2021
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Jan 28, 2022
…A#935)

Only 'Allow to force e-invoice export state' group can
OCA-git-bot pushed a commit to Borruso/l10n-italy that referenced this pull request Feb 4, 2022
…A#935)

Only 'Allow to force e-invoice export state' group can
iwkse pushed a commit to iwkse/l10n-italy that referenced this pull request Feb 5, 2022
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Feb 24, 2023
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Apr 20, 2023
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Apr 21, 2023
…A#935)

Only 'Allow to force e-invoice export state' group can
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Jun 23, 2023
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jul 13, 2023
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Jul 21, 2023
…A#935)

Only 'Allow to force e-invoice export state' group can
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Jul 21, 2023
…A#935)

Only 'Allow to force e-invoice export state' group can
odooNextev pushed a commit to odooNextev/l10n-italy that referenced this pull request Sep 11, 2023
…A#935)

Only 'Allow to force e-invoice export state' group can
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants