Feature/refactor address format stylesheet #3
Conversation
eternalharvest
force-pushed
the
feature/refactor_address_format_stylesheet
branch
2 times, most recently
from
00278dc
to
8bb6697
Compare
|
@eternalharvest Thanks a lot for your PR! It looks like a very nice adjustment. We will review this shortly. (I only noticed this PR now. I somehow didn't get an email.) |
l10n_jp_address_layout/.editorconfig
Outdated
| @@ -0,0 +1,16 @@ | |||
| # EditorConfig helps developers define and maintain consistent | |||
There was a problem hiding this comment.
I'm using vim and the default indent of vim is tab.
So, I need to take care about indent size when I edit code...
editorconfig is not only for vim editor.
Almost all modern IDE support this file within itself or some plugin.
I think editorconfig helps any developers work.
But If you don't want to include this file within this repo,
I'll rebase to remove this patch from change-sets of this PR.
Anyway, thank u for reviewing my PR.
FYI: As u may know what is the editorconfig already, please refere to the following link.
http://editorconfig.org/
There was a problem hiding this comment.
@eternalharvest Could you please remove .editorconfig file since having something for IDE/editor is outside the scope of this repository. No need to rebase this time although it's also fine if you do so.
There was a problem hiding this comment.
@eternalharvest Thank you very much for the PR. I'd suggest you add yourself to the list of contributors in README.rst.
Another thing - could you please sign OCA CLA https://odoo-community.org/page/cla for future contributions? I think it is not needed this time since we do not have any machine code in this module. Thank you!
| <?xml version="1.0" encoding="utf-8"?> | ||
| <odoo> | ||
| <data noupdate="0"> | ||
| <template id="assets_common" inherit_id="web.assets_backend"> |
There was a problem hiding this comment.
It'd be more appropriate to name template id assets_backend instead of assets_common.
There was a problem hiding this comment.
Sorry, It's my typo!
I fixed the template id.
And I removed the editorconfig file and added my self to the list of contribution.
I'll try to sign OCA CLA.
eternalharvest
force-pushed
the
feature/refactor_address_format_stylesheet
branch
2 times, most recently
from
6f4cccc
to
06ecdab
Compare
eternalharvest
force-pushed
the
feature/refactor_address_format_stylesheet
branch
from
06ecdab
to
1636367
Compare
|
@eternalharvest Thank you very much! |
I refactor the style sheet related to the address format.
Just look these images...
BEFORE
AFTER
From now on, Japanese zip code symbol "〒" is not shown in editing mode (readonly).
It seems the height of drop-down list (state) is shorter than other fields, but i think this is another issue of odoo style sheet.