Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0[MIG] l10n_jp_partner_title_qweb: Migration to 16.0 #32

Merged

Conversation

AungKoKoLin1997
Copy link
Contributor

No description provided.

yostashiro and others added 9 commits November 22, 2022 16:39
* [ADD] l10n_jp_partner_title_qweb

* minor adjustments

* remove blank line

* [FIX] wrong object reference

* remove onchu translation

* [IMP] add constraint

* show title field

* [FIX] version

* add tests

* [FIX] enable japanese
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-japan-12.0/l10n-japan-12.0-l10n_jp_partner_title_qweb
Translate-URL: https://translation.odoo-community.org/projects/l10n-japan-12-0/l10n-japan-12-0-l10n_jp_partner_title_qweb/
Remove the tile proposal logic of res.partner to avoid the complexity - in some cases
an 'individual' partner in Odoo could be an organization, etc., and we conclude that
we should not have a rigid proposal logic in this module.
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-l10n_jp_partner_title_qweb branch from eebc3e2 to 249560b Compare November 22, 2022 10:09
Copy link
Sponsor Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AungKoKoLin1997 Can you please review this PR #28 first and then base your migration on that?

@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as draft December 28, 2022 03:43
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-l10n_jp_partner_title_qweb branch from 3bb58cf to 8c8a265 Compare December 28, 2022 04:01
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review December 28, 2022 04:01
Copy link
Sponsor Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Copy link

@kakurai8 kakurai8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yostashiro
Copy link
Sponsor Member

/ocabot merge nobump

Copy link

@kakurai8 kakurai8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostashiro yostashiro merged commit 8a37aab into OCA:16.0 Dec 30, 2022
kakurai8 added a commit to qrtl/fal-oca that referenced this pull request Dec 30, 2022
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-32-by-yostashiro-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-32-by-yostashiro-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2a3ab03. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants