[15.0][ADD] l10n_jp_partner_zip_address #40
Conversation
| request_url = ( | ||
| "http://zipcloud.ibsnet.co.jp/api/search?zipcode" "=%s" % self.zipcode | ||
| ) | ||
| request = urllib.request.Request(request_url) | ||
| response_data = json.loads( | ||
| urllib.request.urlopen(request).read().decode("utf-8") | ||
| ) | ||
| self.state_id = False | ||
| self.city = False | ||
| self.street = False | ||
| self.street2 = False | ||
| if response_data["status"] != 200: | ||
| self.zipcode = False | ||
| return { | ||
| "warning": { | ||
| "title": _("Error"), | ||
| "message": response_data["message"], | ||
| } | ||
| } | ||
| else: | ||
| address_data = response_data["results"] |
There was a problem hiding this comment.
Can we split the connection part into a separate method with an exception handling?
Consider using requests instead of urllib.
AungKoKoLin1997
force-pushed
the
15.0-add-partner_post_codxe
branch
from
d2ee6aa
to
d0d9948
Compare
yostashiro
force-pushed
the
15.0-add-partner_post_codxe
branch
from
3b5168a
to
a88200a
Compare
There was a problem hiding this comment.
@AungKoKoLin1997 I've added a commit. Please review the changes and if OK, please add tests.
yostashiro
changed the title
AungKoKoLin1997
force-pushed
the
15.0-add-partner_post_codxe
branch
from
69a735e
to
f510e17
Compare
|
For some reason, the translation is not reflected. "Only digits are allowed" has been translated |
Fixed it. I had made a mistake with the translation file directory. |
|
@AungKoKoLin1997 Can you please squash commits and push once you confirm the udpate. |
AungKoKoLin1997
force-pushed
the
15.0-add-partner_post_codxe
branch
from
a739b43
to
5d1869c
Compare
|
I have confirmed that the translation has been applied. |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at e9f4a84. Thanks a lot for contributing to OCA. ❤️ |
@qrtl