Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] spargere modul stock account #942

Merged
merged 9 commits into from Apr 26, 2024

Conversation

dhongu
Copy link
Contributor

@dhongu dhongu commented Apr 22, 2024

împărțirea codului din modulul stoc_account in 3 module distincte

  • l10n_ro_stock_account - modulul de baza pentru determinarea conturilor
  • l10n_ro_stock_account_landed_cost - adaugare costuri aditionale pentru diferentele de pret
  • l10n_ro_stock_account_tracking - evaluarea pe locatie si pe loturi

@OCA-git-bot
Copy link
Contributor

Hi @feketemihai, @mcojocaru,
some modules you are maintaining are being modified, check this out!

@@ -94,18 +89,12 @@ def _compute_account(self):
account = loc_scr.l10n_ro_property_stock_valuation_account_id
if svl.account_move_id:
for aml in svl.account_move_id.line_ids.sorted(
lambda l: l.account_id.code
lambda layer: layer.account_id.code
):
if aml.account_id.code[0] in ["2", "3"]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trebuie sa eliminam si 378 (diferenta de pret la marfuri, din categorie produs).

("internal_transfer", "Internal Transfer"),
("internal_transfer_out", "Internal Transfer Out"),
("internal_transfer_in", "Internal Transfer In"),
("internal_transit", "Internal Transit"), # de eliminat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pai sa-l eliminam, acest tip de valuation nu ar trebui sa existe.

@@ -27,7 +27,7 @@ class ProductTemplate(models.Model):
)

def _get_product_accounts(self):
accounts = super(ProductTemplate, self)._get_product_accounts()
accounts = super()._get_product_accounts()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pentru iesire din stock;
Uneori avem nevoie sa facem cheltuiala pe un alt. Ex: 301 = 601, dar pentru anumite consumuri avem nevoie de alt cont decat 601. Astfel ne-ar ajuta sa avem posibilitatea pe cheltuiala sa putem pune un cont pe location_dest_id, pe care sa-l folosim ca alternativa.
Linia 66.

@dhongu
Copy link
Contributor Author

dhongu commented Apr 26, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-942-by-dhongu-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 380d006 into OCA:16.0 Apr 26, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ba9df87. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants