-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] l10n_es_aeat_mod130 #1079
Conversation
Hey @victormmtorres, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
9f3fc51
to
28a8b8a
Compare
cc @Tecnativa |
28a8b8a
to
43aa5da
Compare
Está ya listo para revisar? |
Creo que ya esta bastante avanzado y se puede revisar, pero si veo que aun no pasa Travis ni Runbot por lo que ire machacando los errores |
OK, me espero a que avises que está ya en verde. |
43aa5da
to
48253fe
Compare
Travis is green but not Runbot. Help wanted with Runbot, no Warning or Errors inside Full logs |
Fails every time try force rebuild runbot |
@victormmtorres podrías añadir tests al módulo? Echa un vistazo al del 111 para inspirarte (https://github.com/OCA/l10n-spain/blob/11.0/l10n_es_aeat_mod111/tests/test_l10n_es_aeat_mod111.py):
|
b3be4d6
to
2b7594b
Compare
Changes done @pedrobaeza |
4706640
to
4701115
Compare
@pedrobaeza please review |
c2abf09
to
14ce727
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Con los últimos cambios realizados debería estar todo correcto, aunque mantengo sin fusionar hasta confirmación del cliente
…- IRPF pago fraccionado estimación directa
…ar código 0339 en la presentación.
* Clases a CapWords * PEP8 * Icono del modulo
…s no son trimestrales + PEP8 79 cols
171fe1c
to
312d1b4
Compare
- Remove redundant fields - Expenses of difficult justification - Monetary type in fields - Adjust BOE export format - Adjust views - Test BOE export - Other fine tuning
312d1b4
to
da1f24b
Compare
No description provided.