New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][FIX] l10n_es_facturae: The bank code should be obtained from the mandate in direct debits #1246
[11.0][FIX] l10n_es_facturae: The bank code should be obtained from the mandate in direct debits #1246
Conversation
…date in direct debits The bank code is being acquired from the field `partner_bank_id` of the invoice but this field can be null. The bank code must be acquired from the same field `partner_bank_id' but from the mandate `mandate_id` just as the other bank data as IBAN and BIC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sé si debería serinvoice.partner_bank_id.bank_id.code or invoice.mandate_id.partner_bank_id.bank_id.code
.
Aunque personalmente creo que debe ser exactamente lo mismo, ya que el mandato generalmente es para una única cuenta.
:LGTM: Por mi parte creo que es mejor dejarlo así.
Por cierto, @eantones en este repositorio de la OCA se puede escribir en español, ya que es una localización 😉 |
Muchas gracias @etobella No creo que sea lo mismo ya que en una factura con método de pago "Adeudo directo" el campo Saludos :-) |
Cuando se cambia el mandato, se cambia |
Realmente no cambia nada, así que por mi parte lo podemos dejar así |
Lo que aporta es que no devuelva un error al crear la factura electrónica cuando el campo Adicionalmente, por coherencia, si todos los campos del banco se cogen del l10n-spain/l10n_es_facturae/views/report_facturae.xml Lines 337 to 340 in ee1736a
También, en la validación previa, únicamente valida el l10n-spain/l10n_es_facturae/models/account_invoice.py Lines 214 to 215 in e6ce6f2
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
The bank code is being acquired from the field
partner_bank_id
of the invoice but this field can be null.The bank code must be acquired from the same field
partner_bank_id
but from the mandatemandate_id
just as the other bank data as IBAN and BIC.Can you review it please?
cc @etobella @pedrobaeza