Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] l10n_es_account_banking_sepa_fsdd #1315

Merged
merged 14 commits into from Aug 18, 2020
Merged

[13.0][MIG] l10n_es_account_banking_sepa_fsdd #1315

merged 14 commits into from Aug 18, 2020

Conversation

misern2
Copy link
Contributor

@misern2 misern2 commented Mar 13, 2020 •
edited

Standard Migration

Depende de OCA/bank-payment#686

@misern2 misern2 force-pushed the 13.0-mig-l10n_es_account_banking_sepa_fsdd branch from 4f1afb8 to 4e4ef95 Compare March 18, 2020 21:34
@misern2 misern2 mentioned this pull request Mar 19, 2020
Closed
35 tasks
omar7r and others added 13 commits August 5, 2020 17:29
@omar7r @misern2
[REN][IMP] l10n_es_account_banking_sepa_fsdd: Se renombra el módulo p…
2aaa40b 
…ara incluir el prefijo de la localización, se cambia la configuración del cobro financiado de la orden al modo de pago y la acción al tiempo de exportación
@oca-transbot @misern2
OCA Transbot updated translations from Transifex
6855429
@luismontalba @misern2
[MIG] l10n_es_account_banking_sepa_fsdd: Migrated to 10.0
73869b5
@oca-transbot @misern2
OCA Transbot updated translations from Transifex
c680c0e
@misern2
[MIG] l10n_es_account_banking_sepa_fsdd: Migration to 11.0
efb629e
@oca-travis @misern2
[UPD] Update l10n_es_account_banking_sepa_fsdd.pot
1ac5500
@mtbochaca @misern2
Translated using Weblate (català)
e9bb54f 
Currently translated at 100,0% (4 of 4 strings)

Translation: l10n-spain-11.0/l10n-spain-11.0-l10n_es_account_banking_sepa_fsdd
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-11-0/l10n-spain-11-0-l10n_es_account_banking_sepa_fsdd/ca/
@pedrobaeza @misern2
[MIG] l10n_es_account_banking_sepa_fsdd: Migration to 12.0
a2f84ea 
* Standard procedure
* README by fragments
@oca-travis @misern2
[UPD] Update l10n_es_account_banking_sepa_fsdd.pot
3b70117
@oca-transbot @misern2
Update translation files
a731975 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@OCA-git-bot @misern2
[ADD] icon.png
8ed6725
@OCA-git-bot @misern2
[UPD] README.rst
8d18ee3
@misern2
[IMP] l10n_es_account_banking_sepa_fsdd: black, isort
9faf669
@misern2 misern2 force-pushed the 13.0-mig-l10n_es_account_banking_sepa_fsdd branch 2 times, most recently from 40a7558 to 97f96a6 Compare August 8, 2020 20:24
@pedrobaeza pedrobaeza added this to the 13.0 milestone Aug 11, 2020
@pedrobaeza
Copy link
Member

@misern2 revisa por favor los tests que no son correctos, ya que intenta cargar l10n_generic_coa.

@misern2
Copy link
Contributor Author

misern2 commented Aug 12, 2020

@pedrobaeza Estoy medio de "vacas". La semana que viene subo los tests!.

@pedrobaeza
Copy link
Member

OK, cuando puedas. Disfruta de las vacaciones!

@misern2 misern2 force-pushed the 13.0-mig-l10n_es_account_banking_sepa_fsdd branch from 97f96a6 to 6e9693c Compare August 18, 2020 10:56
@misern2
Copy link
Contributor Author

misern2 commented Aug 18, 2020

@pedrobaeza Ya tienes subido los test. Al final he tenido que quitar la dependencia que había y he replicado la lógica en este test.

@pedrobaeza
Copy link
Member

Ya veo, pero la verdad es que la solución no me gusta mucho, porque duplica un montón de código del test anterior. La solución definitiva debería ser no depender en el módulo account_banking_sepa_direct_debit de l10n_generic_coa, pero mientras tanto, voy a empujar un commit para facilitar la herencia de ese test, haciendo configurable qué plan cargar, y volveremos a la situación anterior de los tests, ¿OK? Voy haciéndolo yo y si has permitido hacer push en tu repo, empujo yo el cambio.

@pedrobaeza
Copy link
Member

Solucionado problema de compatibilidad en herencia en OCA/bank-payment@24a4bf8

Ahora necesito permiso en vuestro fork para poder empujar la versión compatible. Si quieres incluir tú el cambio, aquí tienes la versión funcional:

Tecnativa@821f3df

@misern2
Copy link
Contributor Author

misern2 commented Aug 18, 2020

@pedrobaeza Tienes más razón que un santo. Queda mucho más elegante y no duplicamos código 👍
a te he dado permisos para hacer el push ..
Si te de problemas me avisas

@pedrobaeza pedrobaeza force-pushed the 13.0-mig-l10n_es_account_banking_sepa_fsdd branch from 6e9693c to 821f3df Compare August 18, 2020 15:41
@pedrobaeza
Copy link
Member

OK, ya he empujado, así que a fusionar si no hay nada raro (con las traducciones por ejemplo, que solo se generan al fusionar):

/ocabot merge nobump

Gracias por el PR

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-1315-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e1ea96c into OCA:13.0 Aug 18, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5dd3023. Thanks a lot for contributing to OCA. ❤️

pedrobaeza pushed a commit to sygel-technology/l10n-spain that referenced this pull request Oct 23, 2020
@OCA-git-bot
Merge PR OCA#1315 into 13.0
c63d658 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@misern2 @pedrobaeza @OCA-git-bot @omar7r @oca-transbot @luismontalba @oca-travis @mtbochaca