Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] l10n_es_cnae: Migration to 17.0 #3616

Merged
merged 7 commits into from
May 29, 2024

Conversation

manuelregidor
Copy link
Contributor

@manuelregidor manuelregidor commented May 29, 2024

La importación de las industrias se realiza desde el asistente del módulo l10n_eu_nace al no poderse generar directamente desde un fichero csv en esta versión, ya que las industrias padre no disponen de un identificador externo.

@manuelregidor manuelregidor changed the title [MIG] l10n_es_cnae: Migration to 17.0 [WIP][MIG] l10n_es_cnae: Migration to 17.0 May 29, 2024
@manuelregidor manuelregidor marked this pull request as draft May 29, 2024 11:36
@pedrobaeza
Copy link
Member

Este módulo no hace falta así en esta forma, ya que está el general l10n_eu_nace en OCA/community-data-files

@ValentinVinagre
Copy link
Contributor

ValentinVinagre commented May 29, 2024

@pedrobaeza pero faltan códigos que si están en el cnae. @HaraldPanten puedes confirmar?

@HaraldPanten
Copy link
Contributor

@pedrobaeza Sí es necesario, ya que hay códigos CNAE que no trae el módulo l10n_eu_nace, que son los definidos en este módulo.

Sin embargo, sí son CNAE existentes : 10.21, 10.22... Puedes verlo aquí --> https://www.cnae.com.es/

Es por eso que creasteis este módulo ya hace años --> #414 (comment)

@HaraldPanten
Copy link
Contributor

ocabot migration l10n_es_cnae

@HaraldPanten
Copy link
Contributor

/ocabot migration l10n_es_cnae

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 29, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 29, 2024
46 tasks
@HaraldPanten
Copy link
Contributor

Añado más info:

En este listado --> https://ec.europa.eu/competition/mergers/cases/index/nace_all.html

No están incluidos.

@manuelregidor
Copy link
Contributor Author

@pedrobaeza
Copy link
Member

OK entonces.

@manuelregidor manuelregidor changed the title [WIP][MIG] l10n_es_cnae: Migration to 17.0 [MIG] l10n_es_cnae: Migration to 17.0 May 29, 2024
@manuelregidor manuelregidor marked this pull request as ready for review May 29, 2024 14:11
Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probado en runboat. LGTM.

@pedrobaeza go?

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-3616-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f9e19a2 into OCA:17.0 May 29, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7b87289. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-mig-l10n_es_cnae branch May 29, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants