[9.0][MIG] l10n_es_account_invoice_sequence: Migration to 9.0 #418

pedrobaeza · 2016-12-24T14:12:31Z

Tests completos
Todos los flujos cubiertos
Arreglo de los diarios existentes en la instalación

pedrobaeza · 2016-12-24T14:12:57Z

pedrobaeza · 2016-12-24T15:59:54Z

l10n_es_account_invoice_sequence/models/account_invoice.py

-        return re
+            # Include the invoice reference on the created journal item
+            # This is done for displaying the number on the conciliation
+            inv.move_id.ref = (


@jalzaga con esto, ya no tendrás el problema de que no te aparece el nº de factura en account_followup o en el asistente de conciliación

yajo

Revisión de código, algunos comentarios no críticos.

yajo · 2016-12-27T09:24:04Z

l10n_es_account_invoice_sequence/constants.py

+    'l10n_es.account_chart_template_assoc',
+    'l10n_es.account_chart_template_pymes',
+    'l10n_es.account_chart_template_full',
+]


Normalmente prefiero que estas cosas las devuelvan métodos @api.model, por posibilitar sobrecargas. Podrías usar ormcache + un consejillo que te pongo más abajo para tener mejor rendimiento. De todas formas, no es crítico.

yajo · 2016-12-27T09:24:53Z

l10n_es_account_invoice_sequence/models/account_invoice.py

+# © 2011 NaN Projectes de Programari Lliure, S.L.
+# © 2014 Ángel Moya (Domatix)
+# © 2014 Roberto Lizana (Trey)
+# © 2013-2016 Pedro M. Baeza


OCA/maintainer-tools#197, aquí y en otros lugares del PR.

yajo · 2016-12-27T09:26:41Z

l10n_es_account_invoice_sequence/models/account_invoice.py

        for inv in self:
            if not inv.invoice_number:
                sequence = inv.journal_id.invoice_sequence_id
+                if inv.type in ['out_refund', 'in_refund']:


Como solo son 2 elementos, tampoco es muy crítico, pero igual te interesa saberlo: http://stackoverflow.com/a/2831242/1468388

yajo · 2016-12-27T09:29:50Z

l10n_es_account_invoice_sequence/models/account_journal.py

+        if not vals.get('company_id') or vals.get('sequence_id'):
+            return super(AccountJournal, self).create(vals)
+        spanish_charts = reduce(
+            operator.add, [self.env.ref(x) for x in SPANISH_CHARTS],


Interesante método de generar un recordset 😉

Si en lugar de [...] usas (...), tendrás mejor rendimiento. Tampoco parece muy crítico porque son creo que 5 loops o así...

yajo · 2016-12-27T09:32:47Z

l10n_es_account_invoice_sequence/models/account_journal.py

+            journal = self.search([('company_id', '=', company.id)], limit=1)
+            if journal:
+                vals['sequence_id'] = journal.sequence_id.id
+                vals['refund_sequence'] = False


Casi seguro que me estoy confundiendo, pero pregunto: ¿aquí estás hardcodeando que no se trate de una secuencia de facturas rectificativas?

No, se le dice que la secuencia de las rectificativas es diferente. El campo es: "Dedicated Refund Sequence"

https://github.com/OCA/OCB/blob/9.0/addons/account/models/account.py#L245

pedrobaeza · 2017-01-13T12:41:09Z

@yajo, mejoras realizadas

yajo · 2017-01-13T13:01:00Z

l10n_es_account_invoice_sequence/models/account_chart_template.py

+    @api.multi
+    @tools.ormcache()
+    def is_spanish_chart(self):
+        return self[:1] in reduce(


Creo que return self < reduce( sería más fiable.

Cuidadín que reduce() está eliminado en python3.x

https://docs.python.org/3.0/whatsnew/3.0.html#builtins

yajo · 2017-01-13T13:06:43Z

l10n_es_account_invoice_sequence/models/account_chart_template.py

+    def is_spanish_chart(self):
+        return self[:1] in reduce(
+            operator.add,
+            (self.env.ref(x) for x in self._get_spanish_charts_xml_ids()),


I think it would be better to have a self._get_spanish_charts method that does this inside and returns a recordset, just a matter of taste I guess.

Demasiados métodos para algo tan complicado. Para empezar, esto en la vida se va a extender, pero si acaso hiciera falta, es tan fácil como comprobar otra condición, y si no se da, devolver super.

bueno, me refería reemplazando el _get_spanish_charts_xml_ids.

Puf, da más o menos igual, la verdad...

pedrobaeza · 2017-01-13T13:12:05Z

Estoy revisando el error de Travis que no me daba en local.

cubells

Excepto mis 2 comentarios y que en las cabeceras pones 2016 cuando debería de ser 2017 lo veo perfecto.

👍

cubells · 2017-01-13T14:41:35Z

l10n_es_account_invoice_sequence/data/sequence_data.xml

@@ -1,13 +1,14 @@
 <?xml version="1.0" encoding="utf-8"?>
-<openerp>
-    <data noupdate="1">
+<odoo>


No debería de ser odoo noupdate="1" ??

He preferido que sea así, porque si no, alguien puede modificar la secuencia por ejemplo cambiándole la compañía asociada y que eso estropee la creación de un nuevo plan contable. De todas formas, ésta es solo la plantilla, así que siempre se puede modificar la secuencia en concreto una vez generado el plan.

cubells · 2017-01-13T15:00:35Z

l10n_es_account_invoice_sequence/models/account_chart_template.py

+    @api.multi
+    @tools.ormcache()
+    def is_spanish_chart(self):
+        return self[:1] in reduce(


Cuidadín que reduce() está eliminado en python3.x

https://docs.python.org/3.0/whatsnew/3.0.html#builtins

* Full tests * All flows covered * Journal fix on install

Signed-off-by LoisRForgeFlow

pedrobaeza force-pushed the 9.0-l10n_es_account_invoice_sequence branch from e0c64be to 2f100b9 Compare December 24, 2016 15:58

pedrobaeza commented Dec 24, 2016

View reviewed changes

pedrobaeza mentioned this pull request Dec 24, 2016

Migration to version 9.0 #225

Closed

31 tasks

yajo approved these changes Dec 27, 2016

View reviewed changes

yajo mentioned this pull request Dec 27, 2016

[10.0] [MIG] l10n_es_account_invoice_sequence #419

Merged

pedrobaeza force-pushed the 9.0-l10n_es_account_invoice_sequence branch from 5162d8b to c7390f2 Compare January 13, 2017 12:57

yajo approved these changes Jan 13, 2017

View reviewed changes

cubells approved these changes Jan 13, 2017

View reviewed changes

pedrobaeza force-pushed the 9.0-l10n_es_account_invoice_sequence branch 2 times, most recently from 66a5290 to 3cc45b8 Compare January 13, 2017 18:22

[MIG] l10n_es_account_invoice_sequence: Migration to 9.0

8fe865f

* Full tests * All flows covered * Journal fix on install

pedrobaeza force-pushed the 9.0-l10n_es_account_invoice_sequence branch from 3cc45b8 to 8fe865f Compare January 14, 2017 10:37

pedrobaeza merged commit 2926d3c into OCA:9.0 Jan 14, 2017

pedrobaeza deleted the 9.0-l10n_es_account_invoice_sequence branch January 14, 2017 11:18

ao-landoo pushed a commit to landoo-es/l10n-spain that referenced this pull request Aug 12, 2022

Merge PR OCA#418 into 15.0

37fc0e5

Signed-off-by LoisRForgeFlow

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0][MIG] l10n_es_account_invoice_sequence: Migration to 9.0 #418

[9.0][MIG] l10n_es_account_invoice_sequence: Migration to 9.0 #418

pedrobaeza commented Dec 24, 2016

pedrobaeza commented Dec 24, 2016

pedrobaeza Dec 24, 2016

yajo left a comment

yajo Dec 27, 2016

yajo Dec 27, 2016

yajo Dec 27, 2016

yajo Dec 27, 2016

yajo Dec 27, 2016

oihane Jan 3, 2017

pedrobaeza commented Jan 13, 2017

yajo Jan 13, 2017

cubells Jan 13, 2017

yajo Jan 13, 2017

pedrobaeza Jan 13, 2017

yajo Jan 13, 2017

pedrobaeza Jan 13, 2017

pedrobaeza commented Jan 13, 2017

cubells left a comment

cubells Jan 13, 2017

pedrobaeza Jan 13, 2017

cubells Jan 13, 2017

cubells Jan 13, 2017

[9.0][MIG] l10n_es_account_invoice_sequence: Migration to 9.0 #418

[9.0][MIG] l10n_es_account_invoice_sequence: Migration to 9.0 #418

Conversation

pedrobaeza commented Dec 24, 2016

pedrobaeza commented Dec 24, 2016

Choose a reason for hiding this comment

yajo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Jan 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Jan 13, 2017

cubells left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment