Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][MIG] account_balance_reporting_xls #630

Closed

Conversation

ValentinVinagre
Copy link
Contributor

Migración del módulo account_balance_reporting_xls a versión 9.0.
Debido a que el motor de excels ha cambiado, se ha renombrado el módulo a account_balance_reporting_xlsx.

valentin vinagre urteaga added 2 commits August 30, 2017 12:16
Deleted account_balance_reporting_xls.
Added account_balance_reporting_xlsx.
Delete import logging
@pedrobaeza
Copy link
Member

Creo que es mejor que terminemos la revisión de la v10 y entonces volquemos aquí el resultado.

@ValentinVinagre
Copy link
Contributor Author

@pedrobaeza Me parece correcto.

@pedrobaeza pedrobaeza mentioned this pull request Aug 30, 2017
31 tasks
@misern2 misern2 force-pushed the 9.0-account_balance_reporting_xlsx branch from 9652a2e to 785f21f Compare October 22, 2017 18:58
@misern2
Copy link
Contributor

misern2 commented Oct 22, 2017

@pedrobaeza ,
Primero agradecerte la aportación de los tests

Ahora estaba intentando incorporar tu commit a este PR pero travis no pasa los tests.
Puedes verificar si he realizado el cherry pick correctamente ?

Gracias,

@misern2 misern2 force-pushed the 9.0-account_balance_reporting_xlsx branch from f4c8336 to f756b57 Compare November 12, 2017 20:41
@misern2 misern2 force-pushed the 9.0-account_balance_reporting_xlsx branch from fe75fa8 to 1522752 Compare November 13, 2017 12:24
@misern2
Copy link
Contributor

misern2 commented Nov 13, 2017

@pedrobaeza Ya modifiqué el módulo para la V9 y he añadido tu commit de los test de la versión 10. A ver si está correcto!.

@pedrobaeza
Copy link
Member

Ya hemos hecho el reemplazo completo hacia l10n_es_mis_report, por lo que este viejo motor no tiene sentido que se prorrogue, así que cierro aquí.

@pedrobaeza pedrobaeza closed this May 7, 2018
@chusamo chusamo deleted the 9.0-account_balance_reporting_xlsx branch June 4, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants