-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace PIL renderer with Reportlab renderer #105
Conversation
👍 Works nicely even with standard Ubuntu python-reportlab packages |
Maybe we should add a migration step that reset vertical and horizontal delta |
That's a good idea, since quite a few people might be migrating |
👍 Would be great to add migration step to convert those mm in inches. |
👍 |
@@ -23,22 +23,22 @@ msgstr "Données BVR" | |||
|
|||
#. module: l10n_ch_payment_slip | |||
#: field:res.company,bvr_delta_horz:0 | |||
msgid "BVR Horz. Delta (px)" | |||
msgid "BVR Horz. Delta (inch)" | |||
msgstr "Décalage horizontal global en pixels" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation still says "en pixels", should be "en pouces" (same comment for the other translations in the file)
Do you have any idea when the pull request will be validated? |
It allows to have lighter, faster, vectorial payment slip. This should fix most of current performance and OCR issues
in a4 paper format. A courtesy of @guewen
16e34ef
to
b8297b8
Compare
Branche rebased and french translation corrected |
@lsimonin I guess it can be merged now except, if a reviewer insists to have a migration script in this PR |
@nbessi Thank's for you response. I waiting for the merge. |
👍 |
Can you make a patch or merge this PR? i would'like to test this. |
@lsimonin you can try directly without waiting it to be merged ?? |
@lsimonin Thanks for you review. Did you notice that you have several options you can select:
Frederic |
@fclementic2c Thank you response On the tab bvr data i see this. but for example i send 80% of invoices by email and some times by paper. the aim being to avoid the user to edit the configuration |
@lsimonin to merge report we use https://github.com/OCA/reporting-engine/tree/7.0/base_report_assembler but it seems that it is not ported yet in version 8.0. For your other concerns you should open an enchancement issue. They are out of the scope of this PR. |
@lsimonin I will add the missing translation |
Just add need fixing so we don't forget the missing translation |
👍 |
I had a return of the validation of the BVR by Postfinance. |
while waiting community tools or banking addons to be repared
in order to avoid printing on preprinted marks
@lsimonin Fixed |
When I move the address, reference number at the top does not move at the same time in the "Récépissé" |
the bvr was validated by Postfinance |
@lsimonin That's a good new I will fix your last comment ASAP |
Positioning fixed |
Ok let's merge as it was validated by PostFinance |
Replace PIL renderer with Reportlab renderer
Replace PIL renderer with Reportlab renderer
It allows to have lighter, faster, vectorial payment slip.
This should fix most of current performance and OCR issues