Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] Migrate l10n_ch_pain_direct_debit and merge with l10n_ch_lsv_dd #536

Closed
wants to merge 14 commits into from

Conversation

ecino
Copy link

@ecino ecino commented Jan 15, 2020

This allows to generate swiss pain files and simplifies the repository structure, by merging modules lsv_dd with pain_direct_debit module.

@ecino
Copy link
Author

ecino commented Jan 29, 2020

@yvaucher Can you have a look at this one?

@ecino ecino requested a review from yvaucher January 29, 2020 14:45
@ecino ecino force-pushed the 11.0-mig-l10n_ch_pain_direct_debit branch 2 times, most recently from 6670ddd to 44c4484 Compare February 27, 2020 08:29
@ecino ecino mentioned this pull request Feb 27, 2020
21 tasks
@ecino ecino force-pushed the 11.0-mig-l10n_ch_pain_direct_debit branch 2 times, most recently from 94e904f to e039ff4 Compare February 27, 2020 08:59
@ecino ecino force-pushed the 11.0-mig-l10n_ch_pain_direct_debit branch from e039ff4 to 64ac57e Compare February 27, 2020 09:28
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only,

LGTM only a couple of module "cosmetics' otherwise good to be merged.

# © 2016 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

# pylint: disable=C8101
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, C8101 is a check about presence of Odoo Community Association (OCA) in the author list.

My guess is that by removing the space between Association and (OCA) you get a lint error.

This is the reference:

https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py

# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
##############################################################################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to change this to the shord format for headers.

@ecino
Copy link
Author

ecino commented Mar 4, 2020

Thanks, I will make the changes. By testing we saw that the format for Swiss banks direct debit has some specificities that we have to change here and there, so we should wait that we fix these before we merge. I will tell you when it's done and properly tested.

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 6, 2022
@github-actions github-actions bot closed this Mar 13, 2022
@ecino ecino deleted the 11.0-mig-l10n_ch_pain_direct_debit branch May 30, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants