New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0] Migrate l10n_ch_pain_direct_debit and merge with l10n_ch_lsv_dd #536
Conversation
@yvaucher Can you have a look at this one? |
- Allow to generate the payment files from the button Generate Payment File of a payment order. - Update tests
- Added some more tests
- Various bug fixes - Adapt lsv_dd tests to version 10
I merge the l10n_ch_lsv_dd module into the l10n_ch_pain_direct_debit module. correct lint and tests
…irect_debit module
6670ddd
to
44c4484
Compare
94e904f
to
e039ff4
Compare
e039ff4
to
64ac57e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review only,
LGTM only a couple of module "cosmetics' otherwise good to be merged.
# © 2016 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>) | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
||
# pylint: disable=C8101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, C8101 is a check about presence of Odoo Community Association (OCA) in the author list.
My guess is that by removing the space between Association
and (OCA)
you get a lint error.
This is the reference:
https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py
# You should have received a copy of the GNU Affero General Public License | ||
# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
############################################################################## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to change this to the shord format for headers.
Thanks, I will make the changes. By testing we saw that the format for Swiss banks direct debit has some specificities that we have to change here and there, so we should wait that we fix these before we merge. I will tell you when it's done and properly tested. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This allows to generate swiss pain files and simplifies the repository structure, by merging modules
lsv_dd
withpain_direct_debit
module.