Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] l10n_ch_base_bank - reduced #550

Merged
merged 140 commits into from Dec 9, 2020

Conversation

yvaucher
Copy link
Member

@yvaucher yvaucher commented Jun 4, 2020

nbessi and others added 30 commits April 2, 2020 11:02
…artner.bank.

The code is retro compatible and if you do not have a ccp on bank it will act as before
An ISR subscription number is a reserved range of postal account to generate ISR
It must start with 01 or 03

Use more realistic data in tests
Replace "Postal number" by "ISR"
Detect an ISR subscription number based on the leading digits 01 or 03
@yvaucher yvaucher force-pushed the 13-l10n_ch_base_bank-reduced branch from d0bcfb4 to 8fda33c Compare August 13, 2020 15:16
@gurneyalex
Copy link
Member

@yvaucher what is the status of this PR? the last PR on Odoo is closed, and you say it's ok, but #578 is red -> how can we move on here?

@yvaucher
Copy link
Member Author

yvaucher commented Dec 8, 2020

@gurneyalex AFAIK this module has been used since a while on our projects in v13

@yvaucher
Copy link
Member Author

yvaucher commented Dec 8, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-550-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 8, 2020
Signed-off-by yvaucher
@TDu
Copy link
Member

TDu commented Dec 8, 2020

Yes thank you. Go 🤖

@TDu
Copy link
Member

TDu commented Dec 9, 2020

@yvaucher Looks like the merge failed because of duplicate in the .po file https://travis-ci.com/github/OCA/l10n-switzerland/jobs/456034459#L914
Would be great if you could fix and try merging again, thanks.

@yvaucher
Copy link
Member Author

yvaucher commented Dec 9, 2020

@TDu thanks for the pointer

@yvaucher
Copy link
Member Author

yvaucher commented Dec 9, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-550-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a40c767 into OCA:13.0 Dec 9, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8f3550f. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-550-by-yvaucher-bump-nobump, awaiting test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet