Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] l10n_ch_base_bank: Migrate to version 15.0 #659

Closed
wants to merge 145 commits into from
Closed

[15.0][MIG] l10n_ch_base_bank: Migrate to version 15.0 #659

wants to merge 145 commits into from

Conversation

sonhd91
Copy link
Contributor

@sonhd91 sonhd91 commented Jul 19, 2022

No description provided.

@sonhd91 sonhd91 marked this pull request as ready for review July 19, 2022 11:21
@sonhd91 sonhd91 mentioned this pull request Jul 19, 2022
Open
8 tasks
@sonhd91 sonhd91 changed the title [15.0][MIG] l10_ch_base_bank: Migrate to version 15.0 [15.0][MIG] l10n_ch_base_bank: Migrate to version 15.0 Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 4, 2022
@janikvonrotz
Copy link

@nbessi Would be possible to check this PR?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 25, 2022
@ivantodorovich
Copy link

Would you consider including this PR?

ping @santostelmo

@ivantodorovich ivantodorovich mentioned this pull request Jan 4, 2023
Closed
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Iryna Vushnevska and others added 20 commits January 9, 2023 09:36
@sonhd91
[IMP] aplly pre-commit
f087501
@yvaucher @sonhd91
Remove duplicate l10n_ch_postal field on bank account
7e869cf
@yvaucher @sonhd91
[REF] split bank models
0858fec
@yvaucher @sonhd91
Fix tests by desambiguating ISR subscr and postal
b393d43 
An ISR subscription number is a reserved range of postal account to generate ISR
It must start with 01 or 03

Use more realistic data in tests
@yvaucher @sonhd91
Fix removed view
2d82f1a
@yvaucher @sonhd91
Fix test set empty M2O with empty recordset
ecfd304
@yvaucher @sonhd91
Clearing do not have leading 0s
16bc41b
@yvaucher @sonhd91
[REF] l10n_ch_postal onchanges
d9a6afd 
Replace "Postal number" by "ISR"
Detect an ISR subscription number based on the leading digits 01 or 03
@yvaucher @sonhd91
Document
8fef19b
@yvaucher @sonhd91
Signature change of _is_isr_ref
5dc8572
@yvaucher @sonhd91
Adapt to odoo core change that removed _is_isr_ref
be262eb 
Follow the removal from here: odoo/odoo#53815
@yvaucher @sonhd91
[TR] remove useless terms of invoice.py
a6be6a5
@OCA-git-bot @sonhd91
[UPD] README.rst
1313717
@SimoneVagile @sonhd91
[14.0][MIG] l10n_ch_base_bank
ab8447e
@OCA-git-bot @sonhd91
[UPD] README.rst
2931387
@TDu @sonhd91
[14.0][FIX] l10n_ch_base_bank
a2dd3bc 
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
@OCA-git-bot @sonhd91
l10n_ch_base_bank 14.0.1.0.1
a8b3a20
@sonhd91
[MIG] l10n_ch_account_tags: Migration to 14.0
04e7d69
@santostelmo @sonhd91
l10n_ch_base_bank remove isr check
e52ab4e
@sonhd91
[IMP] l10n_ch_base_bank: black, isort, prettier
2de1053
@sonhd91
Copy link
Contributor Author

sonhd91 commented Jan 9, 2023

Would you consider including this PR?

ping @santostelmo

Hello, I just included PR#682 and remove some related tests case, please check it out

@sonhd91 sonhd91 force-pushed the 15.0-mig-l10_ch_base_bank branch 2 times, most recently from c5641a8 to 7eeee7b Compare January 9, 2023 03:42
yvaucher
yvaucher reviewed Jan 9, 2023
View reviewed changes
l10n_ch_base_bank/README.rst Outdated

* `Trobz <https://trobz.com>`_:

* Son Ho <sonhd@trobz.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the structure of contributors, the list was ordered by date of contribution, grouping by company breaks that order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I just updated it, please check again

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 14, 2023
@github-actions github-actions bot closed this Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvaucher yvaucher yvaucher left review comments

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@leemannd leemannd leemannd approved these changes

Assignees
No one assigned
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet