Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] l10n_ch_invoice_reports: remove controller #710

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

janikvonrotz
Copy link

I got a 500er in the portal view caused by the controller. It seems to be 1:1 ported from Odoo 14.0. The API has changed and therefore I propose to remove it entirely.

Copy link

github-actions bot commented Jan 7, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 7, 2024
@ecino
Copy link

ecino commented Jan 8, 2024

@sonhd91 Can you review?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 14, 2024
@TDu TDu changed the title [FIX] remove controller [15.0][FIX] remove controller Feb 2, 2024
@TDu TDu changed the title [15.0][FIX] remove controller [15.0][FIX] l10n_ch_invoice_reports: remove controller May 31, 2024
@TDu
Copy link
Member

TDu commented May 31, 2024

Removing the whole controller because there could be a bug seems a bit harsh...
Also I tested on runboat from the 15.0 branch an I did not have any issue 🤔
The functionality actually works (using the Preview button on the invoice)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants