Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] l10n_us_account_profile #32

Merged
merged 5 commits into from
Jul 9, 2019

Conversation

murtuzasaleh
Copy link
Member

@murtuzasaleh murtuzasaleh commented May 27, 2019

@oca-clabot
Copy link

Hey @murtuzasaleh, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@Swapnesh-SerpentCS
Copy link

Swapnesh-SerpentCS commented Jun 13, 2019

It seems to have different error logs in Travis and OCA Runbot.

Travis fails because of account_payment_batch_process from account-payment but it is already there on OCA dependency list
9

Runbot is failing because of l10n_us_check_writing_address (Which is correct as it is not merged yet #31)

Screenshot from 2019-06-13 17-40-27

Not sure if this is expected here (Cc @pedrobaeza )

Edit: To be followed after #35

@murtuzasaleh murtuzasaleh changed the title [WIP][11.0][MIG] l10n_us_account_profile [11.0][MIG] l10n_us_account_profile Jun 20, 2019
@max3903
Copy link
Sponsor Member

max3903 commented Jul 8, 2019

@murtuzasaleh Can you rebase and add account_banking_reconciliation from https://github.com/OCA/account-reconcile in the dependency?

@murtuzasaleh murtuzasaleh force-pushed the l10n_us_account_profile_v11 branch 2 times, most recently from c1a7119 to 3ae8435 Compare July 9, 2019 07:04
@murtuzasaleh
Copy link
Member Author

@murtuzasaleh Can you rebase and add account_banking_reconciliation from https://github.com/OCA/account-reconcile in the dependency?

Done

@max3903
Copy link
Sponsor Member

max3903 commented Jul 9, 2019

@murtuzasaleh partner_daytopay has been renamed partner_time_to_pay.

@coveralls
Copy link

coveralls commented Jul 9, 2019

Coverage Status

Coverage remained the same at 58.182% when pulling c71ecd4 on murtuzasaleh:l10n_us_account_profile_v11 into 1cf1b9c on OCA:11.0.

@max3903
Copy link
Sponsor Member

max3903 commented Jul 9, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Rebased to 11.0-ocabot-merge-pr-32-by-max3903-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c71ecd4 into OCA:11.0 Jul 9, 2019
OCA-git-bot added a commit that referenced this pull request Jul 9, 2019
Signed-off-by max3903
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f3e628e. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants