Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][IMP] l10us_form_1099 #41

Closed
wants to merge 1 commit into from
Closed

[12.0][IMP] l10us_form_1099 #41

wants to merge 1 commit into from

Conversation

brian10048
Copy link
Sponsor Contributor

@max3903 This is a start for #36

Do you want to totally replace the boolean field or is this an acceptable option to add another field?

I'm needing direction for the second task of #36

For tasks 3 & 4 of #36, should these reports be in the Contacts app menu?

@coveralls
Copy link

coveralls commented Jul 13, 2019 •
edited
Loading

Coverage Status

Coverage increased (+4.5%) to 54.355% when pulling d06f409 on brian10048:12.0 into 1d95949 on OCA:12.0.

@max3903
Copy link
Sponsor Member

max3903 commented Jul 13, 2019

@brian10048 Thank you very much for working on this.

I would replace it because we can deduce the same info from one field.

We will need a migration script though. If the boolean is True, I would set the most common 1099: 1099-MISC.

Here is an example for the 2nd task:
https://github.com/odoo/odoo/blob/12.0/addons/account/report/account_invoice_report.py

For the 3rd and 4th, I updated the issue #36.

@max3903 max3903 added this to the 12.0 milestone Jul 13, 2019
@brian10048
Copy link
Sponsor Contributor Author

@bodedra I added the report files, but I need help making the SQL query correct

@bodedra
Copy link
Member

bodedra commented Jul 17, 2019

@brian10048 sure.

@brian10048 brian10048 changed the title [12.0][IMP] l10us_form_1099 (WIP) [12.0][IMP] l10us_form_1099 Jul 17, 2019
bodedra
bodedra approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test on runbot. LGTM 👍

@max3903
Copy link
Sponsor Member

max3903 commented Jul 17, 2019

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Rebased to 12.0-ocabot-merge-pr-41-by-max3903-bump-minor, awaiting test results.

@murtuzasaleh
Copy link
Member

murtuzasaleh commented Jul 17, 2019 •
edited
Loading

@brian10048 Please squash your commits.

Cc @max3903

@brian10048
[IMP] l10us_form_1099
44a3e50 
- Add a new object 'type.1099' with a char field 'Name',
- Add a many2one field '1099 Type' on res.partner to type.1099,
- Add data for type.1099 with: 1099-A, 1099-B, 1099-C, 1099-CAP, 1099-DIV, 1099-G, 1099-H, 1099-INT, 1099-K, 1099-LTC, 1099-MISC, 1099-OID, 1099-PATR, 1099-Q, 1099-R, 1099-S, 1099-SA, RRB-1099 and SSA-1099
- Add a SQL report object 'account_payment_1099_report' with views
- Add security for new objects
@brian10048
Copy link
Sponsor Contributor Author

@brian10048 Please squash your commits.

Cc @max3903

Squashed into one commit. Thank you to @bodedra for his work on this as well. The squash cleaned up some of the commits he authored.

OCA-git-bot added a commit that referenced this pull request Jul 17, 2019
@OCA-git-bot
Merge PR #41 into 12.0
352ab5a 
Signed-off-by max3903
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 352ab5a. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 approved these changes

@bodedra bodedra bodedra approved these changes

@murtuzasaleh murtuzasaleh murtuzasaleh approved these changes

@smangukiya smangukiya Awaiting requested review from smangukiya

Assignees

@brian10048 brian10048

Labels
approved enhancement merged 🎉 needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brian10048 @coveralls @max3903 @bodedra @OCA-git-bot @murtuzasaleh