New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0] [ADD] Added connector_alndata module. #49
Conversation
Hey @nikitavaghela, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
@nikitavaghela Few comments:
|
bc66dae
to
2e6c14c
Compare
Hello @max3903, All comments are resolved. Please review this. |
2e6c14c
to
849dfee
Compare
@max3903 Fix the duplicate constraint issue because of archived data when fetching apartment data. Travis is failed because of NewConstructions data which not available on alndata.com |
075d64c
to
1087336
Compare
Hello @mgosai, I updated code as your approach please review it. |
50ece60
to
61276df
Compare
As per the @mgosai approach, I added the customer_id field with required=True in the connector_alandata module. But there is raised an issue of NOT NULL constrain like this so to fix this issue I added pre-hook and it's working fine. Now issue that or if we installed first fieldservice_account_analytic module then installing connector_alndata module then same error occurred |
…tner and set to customer_id.
61276df
to
11d7779
Compare
f0f346a
to
c7bd210
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
#48