Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [ADD] Added connector_alndata module. #49

Closed
wants to merge 5 commits into from

Conversation

nikitavaghela
Copy link

@nikitavaghela nikitavaghela commented Nov 14, 2019

  • created connector_alndata module
  • Added fields
  • Added tree, form views and action and menu
  • Added scheduler and check credential using ALN API.

#48

@oca-clabot
Copy link

Hey @nikitavaghela, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

connector_alndata/__manifest__.py Outdated Show resolved Hide resolved
connector_alndata/models/res_partner.py Outdated Show resolved Hide resolved
@max3903
Copy link
Sponsor Member

max3903 commented Nov 14, 2019

@nikitavaghela Few comments:

  • One file per class. Don't mix classes in the same file.
  • No need for a new class apartment. Apartments should be mapped to fsm.location as mentioned in the mapping table.

@max3903 max3903 marked this pull request as ready for review November 26, 2019 15:47
@nikitavaghela nikitavaghela changed the title [WIP] Added connector_alndata module. [12.0] [ADD] Added connector_alndata module. Dec 30, 2019
@nikitavaghela
Copy link
Author

Hello @max3903, All comments are resolved. Please review this.

@nikitavaghela
Copy link
Author

@max3903 Fix the duplicate constraint issue because of archived data when fetching apartment data. Travis is failed because of NewConstructions data which not available on alndata.com

@nikitavaghela nikitavaghela force-pushed the connector_alndata branch 2 times, most recently from 075d64c to 1087336 Compare January 16, 2020 06:59
@nikitavaghela
Copy link
Author

Hello @mgosai, I updated code as your approach please review it.

@nikitavaghela nikitavaghela force-pushed the connector_alndata branch 6 times, most recently from 50ece60 to 61276df Compare January 20, 2020 06:49
@nikitavaghela
Copy link
Author

Hello @mgosai and @max3903,

As per the @mgosai approach, I added the customer_id field with required=True in the connector_alandata module. But there is raised an issue of NOT NULL constrain like this
customer_id_not_null

so to fix this issue I added pre-hook and it's working fine.

Now issue that
if connector_alndata module installed first so it will added customer_id with NOT NULL constraint
and then if we are installing fieldservice_account_analytic module then raised error like this

or if we installed first fieldservice_account_analytic module then installing connector_alndata module then same error occurred

already_exist_customer_id

@nikitavaghela
Copy link
Author

Hello @mgosai , @max3903 ,

Fixed the customer_id NOT NULL constrain issue for connector_alndata module.

Can you please review this?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 31, 2021
@github-actions github-actions bot closed this Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants