Switch to W504 from W503 (line break before a logical operator)

[yelizariev]

Could OCA use W504, i.e.

if (vals.get('model') == 'ir.ui.view'
        and not self.env.context.get('duplicate_view_for_website')):

instead of W503, i.e.

if (vals.get('model') == 'ir.ui.view' and
        not self.env.context.get('duplicate_view_for_website')):

See
PyCQA/pycodestyle#498
https://github.com/PyCQA/pycodestyle/pull/502/files

Feel free to add 👍 or 👎 to this post

[legalsylvain]

I personaly against such rule changes.

• It is matter of tastes, and doesn't provides any improvment.
• requires a lot of changes, travis will fail if we apply this change of rule.
• maintainers have other things more important than cosmetics changes like this. (IMO)

To be clear, I'm not more in favor of W504 than W503 or whatever, I just think that changing that rule will provides problems, without any improvment.

Regards.

[yelizariev]

There is always a way to apply changes softly (deactivate W503 and make W504 beta).

It is matter of tastes, and doesn't provides any improvment.

It's actually allows read code easily. See

[1] https://mail.python.org/pipermail/python-ideas/2016-April/039774.html
[2] http://bugs.python.org/issue26763
[3] https://hg.python.org/peps/rev/3857909d7956

http://rhodesmill.org/brandon/slides/2012-11-pyconca/#laying-down-the-law

maintainers have other things more important than cosmetics changes like this. (IMO)

The contributors too. Why OCA force them to update they code to W503?

[StefanRijnhart]

Agree with @legalsylvain to allow both styles.

[yelizariev]

Allowing both is also a solution

[moylop260]

Changing this style rule we will have too many travis red results.

If the current style was changed and the new one will make us headaches... then what about remove this rule?

Adding it to ignore section of the flake8 configuration file: W503

[yelizariev]

Also, we can disable W503 and apply W504 since odoo 12

[moylop260]

Allowing both is also a solution

The technical solution is ignoring both from the configuration file of flake8.

FYI we have advanced script for pylint (to choose a special configuration file for each odoo version or PR or betas...) but for flake8 (this check is a flake8 one) we don't have this options...

and IMHO allowing both is the same that to disable both.

[moylop260]

FYI I have taken the liberty to have created the following PR:

• [REF] flake8.cfg: Allow W504 and W503 flake8 style #546

[pedrobaeza]

Closed by allowing both in #546