Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow expected errors to also handle linting #228

Closed
wants to merge 2 commits into from

Conversation

dreispt
Copy link
Sponsor Member

@dreispt dreispt commented Aug 16, 2015

Expected error check is moved from server tests to the test controller travis_run_tests.
This allows to expect for types of errors other than server errors, such as lint errors.

Extracted from the PR #223

@yvaucher
Copy link
Member

Thanks for the extraction 👍

@moylop260
Copy link
Contributor

IMHO expected errors of lint should process it each lint script for compatibility with git_hook and use a particular variable by each script to major control.

To know if this work we will need to add some lint errors to MQT.

This change is indeed here: #226
Maybe I will need to add @dreispt author in the commit of this functionallity and discuss this change in other one.

@moylop260
Copy link
Contributor

Other matter is that using the pylint from python you can get a counter of errors (Don't just exit(1 or 0))
Of this way you can to check that you have the exactly errors expected counters.
NOTE: To use python package we need to migrate pylint to python script... to check that works we need add lint tests cases.

@moylop260
Copy link
Contributor

This feature now was merged in next PR:
#230

@dreispt
Can you extract the fix part of travis/travis_install_nightly and create a new PR?

IMHO this PR should be closed.

@moylop260 moylop260 closed this Aug 21, 2015
pedrobaeza added a commit to pedrobaeza/maintainer-quality-tools that referenced this pull request Oct 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants